Publish blob size error limit exceeded metrics #8947
+39
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaeagle99
approved these changes
Jan 9, 2026
| "event_blob_size_error", | ||
| WithDescription("The number of requests that failed due to blob size exceeding limits configured with BlobSizeLimitError and MemoSizeLimitError."), | ||
| ) | ||
| HeaderSize = NewBytesHistogramDef("header_size", WithDescription("The size of the header in bytes passed to the server by the client. This metric is experimental and can be removed in the future.")) |
There was a problem hiding this comment.
nit: Should the spacing be restored so it lines up most of the other metric definitions? Or did the formatter remove the extra space?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new counter event_blob_size_error, which is bumped every time the payloads size (BlobSizeLimitError) or memo size (MemoSizeLimitError) is crossed.
Why?
Currently we do not have a specific metric monitoring blob size errors and ErrBlobSizeExceedsLimit error that is thrown is serviceerror.NewInvalidArgument, which is aggregated with other errors of that kind.
How did you test it?
Potential risks
Any change is risky. Identify all risks you are aware of. If none, remove this section.