Skip to content

Fix: custom domain dns validation without manual intervention #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: custom domain dns validation without manual intervention #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
Binary file not shown.
Binary file added examples/.DS_Store
View file
Open in desktop
Binary file not shown.
13 changes: 6 additions & 7 deletions examples/complete/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,12 @@ module "app_runner_image_base" {
}
}

# # Requires manual intervention to validate records
# # https://github.com/hashicorp/terraform-provider-aws/issues/23460
# create_custom_domain_association = true
# hosted_zone_id = "<TODO>"
# domain_name = "<TODO>"
# enable_www_subdomain = true

# Create a custom domain
create_custom_domain_association = true
enable_www_subdomain = false
hosted_zone_id = var.hosted_zone_id
domain_name = "*.app.example.com"

create_vpc_connector = true
vpc_connector_subnets = module.vpc.private_subnets
vpc_connector_security_groups = [module.security_group.security_group_id]
Expand Down
6 changes: 6 additions & 0 deletions examples/complete/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ variable "repository_url" {
type = string
default = "https://github.com/aws-containers/hello-app-runner" # clone to your account associated with the GitHub connection
}

variable "hosted_zone_id" {
description = "The Route53 zone ID where the validation records for the custom domain will be created"
type = string
default = "Z0975817WMT8ITN8W25F"
}
75 changes: 21 additions & 54 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,60 +433,27 @@ resource "aws_apprunner_custom_domain_association" "this" {
service_arn = aws_apprunner_service.this[0].arn
}

# # Requires manual intervention to validate records
# # https://github.com/hashicorp/terraform-provider-aws/issues/23460
# resource "aws_route53_record" "validation" {
# count = length(aws_apprunner_custom_domain_association.this[0].certificate_validation_records)

# allow_overwrite = true
# name = aws_apprunner_custom_domain_association.this[0].certificate_validation_records.*.name[count.index]
# records = [aws_apprunner_custom_domain_association.this[0].certificate_validation_records.*.value[count.index]]
# ttl = 60
# type = aws_apprunner_custom_domain_association.this[0].certificate_validation_records.*.type[count.index]
# zone_id = var.hosted_zone_id
# }

# resource "aws_route53_record" "validation" {
# for_each = {
# for dvo in aws_apprunner_custom_domain_association.this[0].certificate_validation_records : dvo.name => {
# name = dvo.name
# record = dvo.value
# type = dvo.type
# } if local.create_custom_domain_association
# }

# allow_overwrite = true
# name = each.value.name
# records = [each.value.record]
# ttl = 60
# type = each.value.type
# zone_id = var.hosted_zone_id
# }

# resource "aws_route53_record" "cname" {
# count = local.create_custom_domain_association && var.domain_name_use_cname ? 1 : 0

# allow_overwrite = true
# name = var.domain_name
# records = [aws_apprunner_custom_domain_association.this[0].dns_target]
# ttl = 3600
# type = "CNAME"
# zone_id = var.hosted_zone_id
# }

# resource "aws_route53_record" "alias" {
# for_each = { for k, v in toset(["A", "AAAA"]) : k => v if local.create_custom_domain_association && var.domain_name_use_cname }

# zone_id = var.hosted_zone_id
# name = var.domain_name
# type = each.value

# alias {
# name = aws_apprunner_service.this[0].service_url
# zone_id = <TODO> ???
# evaluate_target_health = true
# }
# }
locals {
validation_records = tolist(aws_apprunner_custom_domain_association.this[0].certificate_validation_records)
}

resource "aws_route53_record" "validation_records" {
count = length([var.domain_name]) + 1
name = local.validation_records[count.index].name
type = local.validation_records[count.index].type
records = [local.validation_records[count.index].value]
allow_overwrite = true
ttl = 300
zone_id = var.hosted_zone_id
}

resource "aws_route53_record" "custom_domain" {
name = aws_apprunner_custom_domain_association.this[0].domain_name
type = "CNAME"
records = [aws_apprunner_service.this[0].service_url]
ttl = 300
zone_id = var.hosted_zone_id
}

################################################################################
# VPC Connector
Expand Down
10 changes: 5 additions & 5 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,11 +220,11 @@ variable "enable_www_subdomain" {
default = null
}

# variable "hosted_zone_id" {
# description = "The ID of the Route53 hosted zone that contains the domain for the `domain_name`"
# type = string
# default = ""
# }
variable "hosted_zone_id" {
description = "The ID of the Route53 hosted zone that contains the domain for the `domain_name`"
type = string
default = ""
}

################################################################################
# VPC Connector
Expand Down
Loading