feat: Add support for deletion protection functionality to table repl… #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
bryantbiggs
reviewed
Aug 15, 2025
bryantbiggs
reviewed
Aug 15, 2025
main.tf
Outdated
| kms_key_arn = lookup(replica.value, "kms_key_arn", null) | ||
| propagate_tags = lookup(replica.value, "propagate_tags", null) | ||
| point_in_time_recovery = lookup(replica.value, "point_in_time_recovery", null) | ||
| deletion_protection_enabled = lookup(replica.value, "deletion_protection_enabled", false) |
Member
There was a problem hiding this comment.
Suggested change
| deletion_protection_enabled = lookup(replica.value, "deletion_protection_enabled", false) | |
| deletion_protection_enabled = lookup(replica.value, "deletion_protection_enabled", null) |
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion. Updated accordingly ;)
Contributor
Author
|
@bryantbiggs may I get your approval in here? |
Contributor
Author
|
@antonbabenko may I get your approval in here? |
bryantbiggs
approved these changes
Aug 26, 2025
antonbabenko
pushed a commit
that referenced
this pull request
Aug 26, 2025
## [5.1.0](v5.0.0...v5.1.0) (2025-08-26) ### Features * Add support for deletion protection functionality to table repl… ([#105](#105)) ([b45a0b6](b45a0b6))
Member
|
This PR is included in version 5.1.0 🎉 |
Contributor
Author
|
Thanks for your help @bryantbiggs and @antonbabenko |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for deletion protection functionality to the table replicas configuration through a new
deletion_protection_enabledargument in theaws_dynamodb_tableresource block, replica configuation. This feature allows users to enable AWS's built-in deletion protection safeguard for table replicas helping prevent accidental or unauthorized deletion of critical infrastructure.hashicorp/terraform-provider-aws#43240
Motivation and Context
This feature was recently introduced in the Terraform AWS Provider, allowing users to enable deletion protection on DynamoDB table replicas. Adding support for this new argument ensures that our module stays up to date with the latest capabilities provided by the AWS provider and allows users to take advantage of built-in safeguards to protect critical infrastructure.
This feature was added in terraform-provider-aws v6.9.0, so a provider upgrade in our module must take place.
Breaking Changes
None. This is a backward-compatible addition. The new
deletion_protection_enabledargument defaults to false, preserving existing behavior for current module users.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request