Skip to content

Conversation

@whoffler
Copy link
Contributor

Description

addons permutations tests

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

},
},
{
Name: "scc-with-appconfig-disabled",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer valid... appconfig is now required

@whoffler whoffler force-pushed the permutationTests branch 3 times, most recently from 5b5518b to f03ff1c Compare November 4, 2025 17:21
@whoffler
Copy link
Contributor Author

whoffler commented Nov 4, 2025

permutation tests passed

[TestAddonPermutations] pass ✔
[TestAddonPermutations] TEST EXECUTION END: TestAddonPermutations - RESULT: PASSED
[TestAddonPermutations] MATRIX TEST COMPLETION: no-addons - PASSED
[TestAddonPermutations] pass ✔
[TestAddonPermutations] TEST EXECUTION END: TestAddonPermutations - RESULT: PASSED
[TestAddonPermutations] MATRIX TEST COMPLETION: observability-with-no-deps - PASSED
[TestAddonPermutations] pass ✔
[TestAddonPermutations] TEST EXECUTION END: TestAddonPermutations - RESULT: PASSED
[TestAddonPermutations] MATRIX TEST COMPLETION: all-addons - PASSED
PASS

@whoffler
Copy link
Contributor Author

whoffler commented Nov 4, 2025

/run pipeline

@whoffler
Copy link
Contributor Author

whoffler commented Nov 5, 2025

/run pipeline

"fully-configurable",
map[string]interface{}{
"prefix": options.Prefix,
"region": "us-south",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we explicitly passing a prefix and region? prefix will now affix a random string to it, and region should have a default value. Our goal is that user will actually not need to pass any inputs. So when I see inputs, its a red flag for me

@ocofaigh ocofaigh merged commit 612495f into main Nov 5, 2025
@ocofaigh ocofaigh deleted the permutationTests branch November 5, 2025 12:21
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.71.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants