-
Notifications
You must be signed in to change notification settings - Fork 15
permutation tests #816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permutation tests #816
Conversation
80055c4 to
a71f430
Compare
a71f430 to
a49b46a
Compare
tests/other_test.go
Outdated
| }, | ||
| }, | ||
| { | ||
| Name: "scc-with-appconfig-disabled", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer valid... appconfig is now required
5b5518b to
f03ff1c
Compare
|
permutation tests passed |
|
/run pipeline |
f03ff1c to
0d7451d
Compare
|
/run pipeline |
tests/other_test.go
Outdated
| "fully-configurable", | ||
| map[string]interface{}{ | ||
| "prefix": options.Prefix, | ||
| "region": "us-south", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we explicitly passing a prefix and region? prefix will now affix a random string to it, and region should have a default value. Our goal is that user will actually not need to pass any inputs. So when I see inputs, its a red flag for me
|
🎉 This PR is included in version 3.71.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
addons permutations tests
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers