Skip to content

feat: Added next steps url for the DA #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 17, 2025
Merged

feat: Added next steps url for the DA #173

merged 19 commits into from
Nov 17, 2025

Conversation

@aatreyee257
Copy link
Contributor

@aatreyee257 aatreyee257 commented Nov 6, 2025

Description

Added next steps url for fully-configurable and security-enforced variations.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added next steps url for fully-configurable and security-enforced variations.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 6, 2025 •
edited
Loading

1.Fully-Configurable
Screenshot 2025-11-06 at 14 57 25
Screenshot 2025-11-06 at 14 57 17

2.Security-Enforced:
Screenshot 2025-11-07 at 02 45 15

Screenshot 2025-11-07 at 02 45 22

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 6, 2025

/run pipeline

@aatreyee257 aatreyee257 marked this pull request as ready for review November 6, 2025 20:52
@iamar7
Copy link
Member

iamar7 commented Nov 10, 2025

/run pipeline

iamar7
iamar7 requested changes Nov 10, 2025
View reviewed changes
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments - please attach UI screenshot with the below changes as well

aatreyee257 and others added 4 commits November 11, 2025 10:07
@aatreyee257 @iamar7
Update solutions/security-enforced/outputs.tf
bcedaff 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257 @iamar7
Update solutions/security-enforced/outputs.tf
dd89394 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257 @iamar7
Update solutions/fully-configurable/outputs.tf
98aceac 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257 @iamar7
Update solutions/fully-configurable/outputs.tf
9de119c 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 11, 2025

/run pipeline

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 12, 2025

/run pipeline

iamar7
iamar7 requested changes Nov 12, 2025
View reviewed changes
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 12, 2025

/run pipeline

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 13, 2025

/run pipeline

@aatreyee257 aatreyee257 requested a review from vkuma17 as a code owner November 14, 2025 09:17
@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 14, 2025

/run pipeline

iamar7
iamar7 requested changes Nov 14, 2025
View reviewed changes
Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

aatreyee257 and others added 2 commits November 17, 2025 11:11
@aatreyee257 @iamar7
Update solutions/fully-configurable/outputs.tf
f80cb98 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257 @iamar7
Update solutions/fully-configurable/outputs.tf
808fd22 
Co-authored-by: Md Anam Raihan <md.anam.raihan17@gmail.com>
@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 17, 2025

/run pipeline

@aatreyee257
Copy link
Contributor Author

aatreyee257 commented Nov 17, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 7b21577 into main Nov 17, 2025
2 checks passed
@ocofaigh ocofaigh deleted the i-16356 branch November 17, 2025 10:51
@terraform-ibm-modules-ops
Copy link
Contributor

terraform-ibm-modules-ops commented Nov 17, 2025

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamar7 iamar7 iamar7 approved these changes

@kierramarie kierramarie Awaiting requested review from kierramarie

@vkuma17 vkuma17 Awaiting requested review from vkuma17 vkuma17 is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aatreyee257 @iamar7 @terraform-ibm-modules-ops @ocofaigh