-
Notifications
You must be signed in to change notification settings - Fork 3
feat: next step url and diagram updates #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diagram flows don't seem correct. Can you use individual lines to show communication. The only flows in this DA are:
- Event Notifications sends failed events to the COS bucket
- The KMS key is used to encrypt and decrypt data
- Event Notifications send platform metrics to Cloud Monitoring
- The COS bucket sends its metrics to Cloud Monitoring
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
|
PR pipeline failed with error, retrying. |
|
/run pipeline |
|
@Ak-sky why is it using a private bucket endpoint? Thats going to fail after re-platforming. It should be using direct |
|
/run pipeline |
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |

Description
nullasorcondition forexisting_cos_instance_crnRelease required?
x.x.X)x.X.x)X.x.x)Release notes content
Added next step URLs in DAs.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers