Skip to content

Conversation

@Ak-sky
Copy link
Member

@Ak-sky Ak-sky commented Oct 6, 2025

Description

  • Added next step URLs in DAs
  • Update diagram for both FC and SE variations.
  • Added null as or condition for existing_cos_instance_crn
  • Update the code for management_endpoint_type_for_bucket.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added next step URLs in DAs.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Ak-sky Ak-sky requested a review from Aashiq-J as a code owner October 6, 2025 14:59
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 6, 2025

image

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 6, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagram flows don't seem correct. Can you use individual lines to show communication. The only flows in this DA are:

  • Event Notifications sends failed events to the COS bucket
  • The KMS key is used to encrypt and decrypt data
  • Event Notifications send platform metrics to Cloud Monitoring
  • The COS bucket sends its metrics to Cloud Monitoring

@Ak-sky Ak-sky requested a review from ocofaigh October 9, 2025 00:07
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 9, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

/run pipeline

1 similar comment
@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

/run pipeline

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

PR pipeline failed with error, retrying.

         2025/10/10 07:49:08 Terraform apply | Error: RequestError: send request failed
         2025/10/10 07:49:08 Terraform apply | caused by: Put "https://s3.private.us-south.cloud-object-storage.appdomain.cloud/cos-bucket-llqw": dial tcp 10.1.129.97:443: i/o timeout
         2025/10/10 07:49:08 Terraform apply | 
         2025/10/10 07:49:08 Terraform apply |   with module.cos.module.buckets.module.buckets["cos-bucket"].ibm_cos_bucket.cos_bucket[0],
         2025/10/10 07:49:08 Terraform apply |   on .terraform/modules/cos/main.tf line 124, in resource "ibm_cos_bucket" "cos_bucket":
         2025/10/10 07:49:08 Terraform apply |  124: resource "ibm_cos_bucket" "cos_bucket" {
         2025/10/10 07:49:08 Terraform apply | 
         2025/10/10 07:49:08 Terraform apply | ---
         2025/10/10 07:49:08 Terraform apply | id: terraform-d2853781
         2025/10/10 07:49:08 Terraform apply | summary: |-
         2025/10/10 07:49:08 Terraform apply |   RequestError: send request failed
         2025/10/10 07:49:08 Terraform apply |   caused by: Put "https://s3.private.us-south.cloud-object-storage.appdomain.cloud/cos-bucket-llqw": dial tcp 10.1.129.97:443: i/o timeout
         2025/10/10 07:49:08 Terraform apply | severity: error
         2025/10/10 07:49:08 Terraform apply | resource: ibm_cos_bucket
         2025/10/10 07:49:08 Terraform apply | operation: create
         2025/10/10 07:49:08 Terraform apply | component:
         2025/10/10 07:49:08 Terraform apply |   name: github.com/IBM-Cloud/terraform-provider-ibm
         2025/10/10 07:49:08 Terraform apply |   version: 1.83.3
         2025/10/10 07:49:08 Terraform apply | ---
         2025/10/10 07:49:08 Terraform apply | 

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

/run pipeline

@ocofaigh
Copy link
Contributor

@Ak-sky why is it using a private bucket endpoint? Thats going to fail after re-platforming. It should be using direct

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

@Ak-sky why is it using a private bucket endpoint? Thats going to fail after re-platforming. It should be using direct

@ocofaigh, I missed this, will fix now.
Should we also remove private from variable validation?

@Ak-sky
Copy link
Member Author

Ak-sky commented Oct 10, 2025

/run pipeline

@ocofaigh ocofaigh merged commit fbdf0e3 into main Oct 10, 2025
2 checks passed
@ocofaigh ocofaigh deleted the en-updates branch October 10, 2025 14:25
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants