Added VPC Quickstart DA with predefined ACL profiles and optional VPC Flow Logs #1082
Conversation
Khuzaima05
changed the title
Khuzaima05
requested review from
maheshwarishikha and
rajatagarwal-ibm
as code owners
|
/run pipeline |
|
Updated the PR as per deep dive discussion :
|
|
Options for quickstart variation: 
|
|
/run pipeline |
1 similar comment
|
/run pipeline |
ocofaigh
left a comment
ocofaigh
left a comment
There was a problem hiding this comment.
Please show in todays playback for team feedback. I also left a few comments, but also the following are missing:
- new variation needs to be added to
.catalog-onboard-pipeline.yaml - new markdown doc needs to be created in the
reference-architecturesfolder. Once this exists, we will need to update our cloud doc to point to it and mention the new variation
solutions/quickstart/README.md
Outdated
| @@ -0,0 +1,3 @@ | |||
| # Cloud automation for VPC (Quickstart) | |||
There was a problem hiding this comment.
The title is wrong - this is no the name of the DA
solutions/quickstart/variables.tf
Outdated
|
|
||
| variable "region" { | ||
| type = string | ||
| description = "The region to provision all resources in. [Learn more](https://terraform-ibm-modules.github.io/documentation/#/region) about how to select different regions for different services." |
There was a problem hiding this comment.
That Learn more link is only valid for variations using addons. This is a monolith so no applicable
ibm_catalog.json
Outdated
| "ignore_readme": true | ||
| }, | ||
| { | ||
| "label": "QuickStart - Basic and Simple", |
There was a problem hiding this comment.
| "label": "QuickStart - Basic and Simple", | |
| "label": "QuickStart - Basic and simple", |
ibm_catalog.json
Outdated
| "description": "The name of an existing resource group to provision the resources." | ||
| }, | ||
| { | ||
| "key": "skip_vpc_cos_iam_auth_policy" |
| { | ||
| "key": "network_acls", | ||
| "description": "Select a predefined ACL profile for the VPC. Options: open (allow all inbound/outbound), common (allow SSH/HTTP/HTTPS with IBM internal + VPC connectivity), ibm-internal (only IBM internal + VPC connectivity), closed (fully restricted).", | ||
| "options": [ |
There was a problem hiding this comment.
these options should be using the rich choice binary widget so more info can be provided in each of the options (instead of in the variable description). Same way we did for the VSI qs
| "name": "quickstart", | ||
| "index": 2, | ||
| "install_type": "fullstack", | ||
| "working_directory": "solutions/quickstart", |
There was a problem hiding this comment.
Both variations are missing the short_description. it should start with the text "Ideal for..." and should be used to differentiate between the two variations.
Currently the "Ideal for" text is showing in the feature list. So need to move out of that and into short_description
Description
Added VPC Quickstart Deployable Architecture with predefined ACL profiles and optional VPC Flow Logs.
Testing
Both confirm VPC creation, subnet provisioning, ACL selection, and flow-log configuration.
issue: https://github.ibm.com/GoldenEye/issues/issues/15496
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
This PR introduces a new VPC Quickstart DA designed to provide a minimal, beginner-friendly way to provision a Virtual Private Cloud on IBM Cloud. It includes simplified defaults, predefined ACL profiles, and an optional COS-backed VPC Flow Logs configuration.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers