feat: addon tests and some variable changes in catalog.json #47

vkuma17 · 2025-09-20T09:01:54Z

Description

Added Addon test and few virtual variables have been exposed in ibm_catalog.json for openshift cluster

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Following variable has been renamed in DA

ocp_version -> openshift_version

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

vkuma17 · 2025-09-20T09:02:07Z

/run pipeline

vkuma17 · 2025-09-20T09:31:33Z

/run pipeline

vkuma17 · 2025-09-20T21:05:25Z

/run pipeline

vkuma17 · 2025-09-20T21:57:32Z

/run pipeline

vkuma17 · 2025-09-21T07:51:56Z

Build has failed 3 times so far. 2 times it failed because I set allow_outbound_traffic to false in ibm_catalog.json.. I think it has to be true as for reaching the redhat marketplace outbound traffic must be allowed. One time it has failed because of timeout building the cluster. Re-running the pipeline again.

vkuma17 · 2025-09-21T07:52:01Z

/run pipeline

vkuma17 · 2025-09-22T07:19:05Z

/run pipeline

vkuma17 · 2025-09-22T15:48:37Z

/run pipeline

vkuma17 · 2025-09-22T15:49:11Z

/run pipeline

vkuma17 · 2025-09-22T18:48:49Z

/run pipeline

ocofaigh

please update to use OCP DA v3.63.1

ocofaigh · 2025-10-09T14:27:58Z

Bump to latest test wrapper version too

vkuma17 · 2025-10-09T16:54:37Z

/run pipeline

tests/pr_test.go

vkuma17 · 2025-10-10T13:28:03Z

/run pipeline

vkuma17 · 2025-10-10T16:44:29Z

cluster is built but it stays in warning state, checked with valerio and he created a debug pod from which any external urls are not accessible, although public gateways are attached and outbound traffic is allowed. Debugging on the issue currently.

vkuma17 · 2025-10-23T14:26:40Z

/run pipeline

vkuma17 · 2025-10-23T16:54:05Z

/run pipeline

vkuma17 · 2025-10-23T19:20:27Z

network_acls were causing the issue. Currently 443,80 and (30000-32767) outbound/inbound was allowed but still when i tried to start an nginx pod it did not come up because image could not be pulled from dockerhub. Allowing all inbound and outbound fixed the problem. But we need to check which other ports should be allowed instead of everything.

Later i faced another issue while virtualization module was running and i have asked Aashiq if he has seen the error before. I saw it twice.
cc: @ocofaigh

2025/10/23 19:11:06 Terraform apply | 1 error occurred:
 2025/10/23 19:11:06 Terraform apply | 	* Internal error occurred: failed calling webhook
 2025/10/23 19:11:06 Terraform apply | "mutate-hyperconverged-hco.kubevirt.io": failed to call webhook: Post
 2025/10/23 19:11:06 Terraform apply | "https://hco-webhook-service.openshift-cnv.svc:4343/mutate-hco-kubevirt-io-v1beta1-hyperconverged?timeout=10s":
 2025/10/23 19:11:06 Terraform apply | tls: failed to verify certificate: x509: certificate signed by unknown
 2025/10/23 19:11:06 Terraform apply | authority
 2025/10/23 19:11:06 Terraform apply |

cluster is built but it stays in warning state, checked with valerio and he created a debug pod from which any external urls are not accessible, although public gateways are attached and outbound traffic is allowed. Debugging on the issue currently.

ocofaigh

@vkuma17 FYI, Aashiq created a PR to update the network ACLs -> #56
However I see you are making them wide open in this PR. Is that what we want to do here? Or should we use the changes he made in that PR?

ocofaigh · 2025-10-24T09:13:02Z

@vkuma17 Aashiq has confirmed we should use what was in his PR - can you update this PR with those changes please?

ocofaigh · 2025-10-24T09:54:40Z

FYI, the last test failed with:

 2025/10/23 19:11:06 Terraform apply | Warning: Helm release created with warnings
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply |   with module.virtualization.helm_release.operator,
 2025/10/23 19:11:06 Terraform apply |   on ../../main.tf line 107, in resource "helm_release" "operator":
 2025/10/23 19:11:06 Terraform apply |  107: resource "helm_release" "operator" {
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | Helm release "d3t6ep2f0cctkv3hsqvg-operator" was created but has a failed
 2025/10/23 19:11:06 Terraform apply | status. Use the `helm` command to investigate the error, correct it, then run
 2025/10/23 19:11:06 Terraform apply | Terraform again.
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | Error: Helm release error
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply |   with module.virtualization.helm_release.operator,
 2025/10/23 19:11:06 Terraform apply |   on ../../main.tf line 107, in resource "helm_release" "operator":
 2025/10/23 19:11:06 Terraform apply |  107: resource "helm_release" "operator" {
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | 1 error occurred:
 2025/10/23 19:11:06 Terraform apply | 	* Internal error occurred: failed calling webhook
 2025/10/23 19:11:06 Terraform apply | "mutate-hyperconverged-hco.kubevirt.io": failed to call webhook: Post
 2025/10/23 19:11:06 Terraform apply | "https://hco-webhook-service.openshift-cnv.svc:4343/mutate-hco-kubevirt-io-v1beta1-hyperconverged?timeout=10s":
 2025/10/23 19:11:06 Terraform apply | tls: failed to verify certificate: x509: certificate signed by unknown
 2025/10/23 19:11:06 Terraform apply | authority

Lets make sure to leave a comment in this PR any time the test fails so we understand what issues we have been seeing

vkuma17 · 2025-10-24T10:43:32Z

FYI, the last test failed with:

 2025/10/23 19:11:06 Terraform apply | Warning: Helm release created with warnings
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply |   with module.virtualization.helm_release.operator,
 2025/10/23 19:11:06 Terraform apply |   on ../../main.tf line 107, in resource "helm_release" "operator":
 2025/10/23 19:11:06 Terraform apply |  107: resource "helm_release" "operator" {
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | Helm release "d3t6ep2f0cctkv3hsqvg-operator" was created but has a failed
 2025/10/23 19:11:06 Terraform apply | status. Use the `helm` command to investigate the error, correct it, then run
 2025/10/23 19:11:06 Terraform apply | Terraform again.
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | Error: Helm release error
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply |   with module.virtualization.helm_release.operator,
 2025/10/23 19:11:06 Terraform apply |   on ../../main.tf line 107, in resource "helm_release" "operator":
 2025/10/23 19:11:06 Terraform apply |  107: resource "helm_release" "operator" {
 2025/10/23 19:11:06 Terraform apply | 
 2025/10/23 19:11:06 Terraform apply | 1 error occurred:
 2025/10/23 19:11:06 Terraform apply | 	* Internal error occurred: failed calling webhook
 2025/10/23 19:11:06 Terraform apply | "mutate-hyperconverged-hco.kubevirt.io": failed to call webhook: Post
 2025/10/23 19:11:06 Terraform apply | "https://hco-webhook-service.openshift-cnv.svc:4343/mutate-hco-kubevirt-io-v1beta1-hyperconverged?timeout=10s":
 2025/10/23 19:11:06 Terraform apply | tls: failed to verify certificate: x509: certificate signed by unknown
 2025/10/23 19:11:06 Terraform apply | authority

Lets make sure to leave a comment in this PR any time the test fails so we understand what issues we have been seeing

I think you missed my above comment @ocofaigh . I had shared the same error
#47 (comment)

…orm-ibm-ocp-virtualization into addon-tests

vkuma17 · 2025-10-25T10:40:37Z

/run pipeline

vkuma17 · 2025-10-25T10:41:06Z

/run pipeline

vkuma17 · 2025-10-25T14:12:47Z

/run pipeline

vkuma17 · 2025-10-25T17:36:54Z

2025-10-25T15:19:42.3351600Z          2025/10/25 15:19:05 Terraform init | request discovery document: Get
2025-10-25T15:19:42.3352099Z          2025/10/25 15:19:05 Terraform init | "https://registry.terraform.io/.well-known/terraform.json": net/http: TLS
2025-10-25T15:19:42.3352578Z          2025/10/25 15:19:05 Terraform init | handshake timeout

last PR failed on this issue during consistency plan.. addon test passed

vkuma17 · 2025-10-26T17:15:34Z

2025/10/23 19:11:06 Terraform apply | 1 error occurred:
 2025/10/23 19:11:06 Terraform apply | 	* Internal error occurred: failed calling webhook
 2025/10/23 19:11:06 Terraform apply | "mutate-hyperconverged-hco.kubevirt.io": failed to call webhook: Post
 2025/10/23 19:11:06 Terraform apply | "https://hco-webhook-service.openshift-cnv.svc:4343/mutate-hco-kubevirt-io-v1beta1-hyperconverged?timeout=10s":
 2025/10/23 19:11:06 Terraform apply | tls: failed to verify certificate: x509: certificate signed by unknown
 2025/10/23 19:11:06 Terraform apply | authority
 2025/10/23 19:11:06 Terraform apply |

This error is occuring because hco-webhook deployment that validates the HyperConverged custom resource contents is not ready in due time. I am increasing wait time between subscription helm chart and CR creation in operator helm chart to 240 seconds from 120 seconds.

vkuma17 · 2025-10-28T00:57:06Z

/run pipeline

vkuma17 · 2025-10-28T07:07:35Z

Upgrade test would fail because we are increasing the delay in time_sleep. Skipping the upgrade test, this is not a breaking change.

         2025/10/28 02:07:23 Terraform plan |   # module.virtualization.time_sleep.wait_for_subscription will be updated in-place
         2025/10/28 02:07:23 Terraform plan |   ~ resource "time_sleep" "wait_for_subscription" {
         2025/10/28 02:07:23 Terraform plan |       ~ create_duration = "120s" -> "240s"
         2025/10/28 02:07:23 Terraform plan |         id              = "2025-10-28T02:01:33Z"
         2025/10/28 02:07:23 Terraform plan |     }
         2025/10/28 02:07:23 Terraform plan | 
         2025/10/28 02:07:23 Terraform plan | Plan: 0 to add, 1 to change, 0 to destroy.

vkuma17 · 2025-10-28T07:08:56Z

/run pipeline

terraform-ibm-modules-ops · 2025-10-28T10:10:50Z

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

GitHub release
v1.4.0

Your semantic-release bot 📦🚀

vkuma17 added 2 commits September 20, 2025 13:59

added addon test

b622e75

updated catalog json

430898b

vkuma17 requested review from Aashiq-J and Aayush-Abhyarthi as code owners September 20, 2025 09:01

updated common-dev-assets

3d96c7e

Update ibm_catalog.json

9e0081a

Merge branch 'main' into addon-tests

230c62e

Update ibm_catalog.json

5885fba

Merge branch 'main' into addon-tests

6afeeb6

ocofaigh requested changes Oct 9, 2025

View reviewed changes

vkuma17 added 2 commits October 9, 2025 22:22

updated test

5c609f6

removed duplicate field

406e855

ocofaigh reviewed Oct 10, 2025

View reviewed changes

tests/pr_test.go Outdated Show resolved Hide resolved

addressed review comment

d85cda9

ocofaigh added 2 commits October 20, 2025 16:10

updates

954d66e

resolve conflicts

cffa1b5

modified network acls

7421d36

ocofaigh mentioned this pull request Oct 24, 2025

fix: update the network acls #56

Closed

6 tasks

ocofaigh reviewed Oct 24, 2025

View reviewed changes

vkuma17 and others added 3 commits October 24, 2025 16:27

Merge branch 'main' into addon-tests

ce8ab86

modified acl rules

99aee07

Merge branch 'addon-tests' of github.com:terraform-ibm-modules/terraf…

6e216ce

…orm-ibm-ocp-virtualization into addon-tests

Merge branch 'main' into addon-tests

a3ec6fe

Update main.tf

9c117d7

vkuma17 added 2 commits October 28, 2025 12:38

SKIP UPGRADE TEST

0b7db5b

SKIP UPGRADE TEST

65a7fcb

ocofaigh approved these changes Oct 28, 2025

View reviewed changes

ocofaigh merged commit 8b05cd5 into main Oct 28, 2025
2 checks passed

ocofaigh deleted the addon-tests branch October 28, 2025 10:10

terraform-ibm-modules-ops added the released label Oct 28, 2025

Uh oh!

feat: addon tests and some variable changes in catalog.json #47

feat: addon tests and some variable changes in catalog.json #47

Conversation

vkuma17 commented Sep 20, 2025

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

vkuma17 commented Sep 20, 2025

Uh oh!

vkuma17 commented Sep 20, 2025

Uh oh!

vkuma17 commented Sep 20, 2025

Uh oh!

vkuma17 commented Sep 20, 2025

Uh oh!

vkuma17 commented Sep 21, 2025

Uh oh!

vkuma17 commented Sep 21, 2025

Uh oh!

vkuma17 commented Sep 22, 2025

Uh oh!

vkuma17 commented Sep 22, 2025

Uh oh!

vkuma17 commented Sep 22, 2025

Uh oh!

vkuma17 commented Sep 22, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

ocofaigh commented Oct 9, 2025

Uh oh!

vkuma17 commented Oct 9, 2025

Uh oh!

Uh oh!

vkuma17 commented Oct 10, 2025

Uh oh!

vkuma17 commented Oct 10, 2025

Uh oh!

vkuma17 commented Oct 23, 2025

Uh oh!

vkuma17 commented Oct 23, 2025

Uh oh!

vkuma17 commented Oct 23, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

ocofaigh commented Oct 24, 2025

Uh oh!

ocofaigh commented Oct 24, 2025

Uh oh!

vkuma17 commented Oct 24, 2025

Uh oh!

vkuma17 commented Oct 25, 2025

Uh oh!

vkuma17 commented Oct 25, 2025

Uh oh!

vkuma17 commented Oct 25, 2025

Uh oh!

vkuma17 commented Oct 25, 2025

Uh oh!

vkuma17 commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkuma17 commented Oct 28, 2025

Uh oh!

vkuma17 commented Oct 28, 2025

Uh oh!

vkuma17 commented Oct 28, 2025

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Oct 28, 2025

Uh oh!

Reviewers

vkuma17 commented Oct 26, 2025 •

edited

Loading