-
Notifications
You must be signed in to change notification settings - Fork 151
fix(no-node-access): support user-event instances returned from custom render #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 96.46% 96.47% +0.01%
==========================================
Files 50 50
Lines 2687 2695 +8
Branches 1112 1111 -1
==========================================
+ Hits 2592 2600 +8
Misses 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this PR solve #1049 also? If so, can you add some tests to cover the reported examples?
You're right — it looks like this does cover the cases from #1049, so I've added tests for them in a757b7e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But codecov complains about the coverage being lower than before.
I added test in 71b22e7. |
## Description <!-- Describe the goal and purpose of this PR. --> The ESLint plugin was broken. There's a fix for it but it's not released yet: testing-library/eslint-plugin-testing-library#1048 ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [ ] Enable backports when necessary (fex. [for bug fixes](https://github.com/camunda/camunda/blob/main/CONTRIBUTING.md#backporting-changes) or [for CI changes](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)). ## Related issues closes #
Checks
Changes
Context
Fixes: Comments below
#1033 (review)