Fix macOS extended attributes error in Docker container operations #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue where macOS extended attributes (like com.apple.provenance) caused Docker putArchive operations to fail with "operation not supported" errors. Simplifies tar command construction to reliably exclude extended attributes on macOS using --no-xattrs and --no-fflags flags. Fixes textcortex#21
This ensures that any changes to a custom Dockerfile are immediately reflected in the built image, rather than using a potentially outdated cached version.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if (process.platform === "darwin") { | ||
| tarCommand += " --no-xattrs --no-fflags"; | ||
| } | ||
| tarCommand += ` -C "${os.homedir()}" .claude`; |
There was a problem hiding this comment.
Bug: MacOS Tar Flags Unreachable
The macOS-specific tar flags (--no-xattrs --no-fflags) for copying the .claude directory are unreachable. The if (process.platform === 'darwin') check is nested within a block that is explicitly skipped on macOS, making this logic dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue where macOS extended attributes (like com.apple.provenance) caused Docker putArchive operations to fail with "operation not supported" errors. Simplifies tar command construction to reliably exclude extended attributes on macOS using --no-xattrs and --no-fflags flags.
Fixes #21