Recognize heredocs in argument lists #73
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now allow heredocs to be preceded by commas, as they are in code such as the
following:
send :method, <<EOF
hello
EOF
|
@aroben I think you need to rebase so this can be merged. |
|
@aroben - I'm doing some housekeeping on Linguist. Any chance you could update this PR so it can be merged? |
|
No rebase is needed I am testing out several heredoc related changes to decide how best to improve them. Hopefully should have something merged within a few days. |
|
Thanks @infininight! |
|
@infininight Did you get a chance to look into these heredoc improvements? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow heredocs to be preceded by commas, as they are in code such as the following: