Skip to content

Conversation

@sandratatarevicova
Copy link

@sandratatarevicova sandratatarevicova commented Sep 4, 2019

This pull request adds support for changing issue status after merging pull request / merge request. The target status and journal author is configurable using environment variables REDMINE_MERGE_REQUEST_LINKS_AFTER_MERGE_STATUS, REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID and REDMINE_MERGE_REQUEST_LINKS_FIXING_KEYWORD_PATTERN.

@sandratatarevicova sandratatarevicova changed the title Change issue status after merge request is merged. #2 Change issue status after merge request is merged. Sep 4, 2019
@sandratatarevicova sandratatarevicova force-pushed the feature/change-status-after-merge branch from 8944612 to 06a2634 Compare September 4, 2019 12:43
@tf
Copy link
Owner

tf commented Sep 5, 2019

Thanks for your contribution. I'll be on vacation next week, but will have a look afterwards. I took a quick peak at the code and saw that the new features are not covered by tests yet. I imagine those new cases will fit in well with the existing unit tests.

Copy link
Owner

@tf tf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good first step. Once tests are added, this can be merged.

@sandratatarevicova
Copy link
Author

@tf If this PR will be merged, we might use the REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID to create journals when merge request is created or updated. Do you think it is good idea? Should I create some issue? :-)

@sandratatarevicova sandratatarevicova force-pushed the feature/change-status-after-merge branch 2 times, most recently from 7830a69 to e6745bd Compare September 18, 2019 12:34
@tf
Copy link
Owner

tf commented Sep 18, 2019

we might use the REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID to create journals when merge request is created or updated.

Oh that could be really cool! Let's do it in a separate PR, though, once this one is merged.

Just now i noticed the "GITLAB" in the name of the variable REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID. What do you think about just calling it REDMINE_MERGE_REQUEST_LINKS_REDMINE_USER_ID instead since it will also be used for journal entries caused by GitHub or Gitea web hook calls?

@sandratatarevicova sandratatarevicova force-pushed the feature/change-status-after-merge branch from e6745bd to db75482 Compare September 18, 2019 12:59
@sandratatarevicova
Copy link
Author

Just now i noticed the "GITLAB" in the name of the variable REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID. What do you think about just calling it REDMINE_MERGE_REQUEST_LINKS_REDMINE_USER_ID instead since it will also be used for journal entries caused by GitHub or Gitea web hook calls?

You are right, the GITLAB in the name of the variable does not make sense. It was probably some thinko :-) Fixed.

@sandratatarevicova sandratatarevicova force-pushed the feature/change-status-after-merge branch from db75482 to 14a7dcd Compare March 25, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants