-
Notifications
You must be signed in to change notification settings - Fork 26
Change issue status after merge request is merged. #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Change issue status after merge request is merged. #20
Conversation
8944612 to
06a2634
Compare
|
Thanks for your contribution. I'll be on vacation next week, but will have a look afterwards. I took a quick peak at the code and saw that the new features are not covered by tests yet. I imagine those new cases will fit in well with the existing unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good first step. Once tests are added, this can be merged.
|
@tf If this PR will be merged, we might use the |
7830a69 to
e6745bd
Compare
Oh that could be really cool! Let's do it in a separate PR, though, once this one is merged. Just now i noticed the "GITLAB" in the name of the variable REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_ID. What do you think about just calling it REDMINE_MERGE_REQUEST_LINKS_REDMINE_USER_ID instead since it will also be used for journal entries caused by GitHub or Gitea web hook calls? |
e6745bd to
db75482
Compare
You are right, the |
db75482 to
14a7dcd
Compare
This pull request adds support for changing issue status after merging pull request / merge request. The target status and journal author is configurable using environment variables
REDMINE_MERGE_REQUEST_LINKS_AFTER_MERGE_STATUS,REDMINE_MERGE_REQUEST_LINKS_GITLAB_REDMINE_USER_IDandREDMINE_MERGE_REQUEST_LINKS_FIXING_KEYWORD_PATTERN.