dlpi: Replace magic number with named constant #1535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded magic number '1' in dlbindreq() with a descriptive constant DLPI_MAX_CONIND. This improves code readability and follows best practices for maintainable code. - Added DLPI_MAX_CONIND constant with clear documentation - Replaced 'req.dl_max_conind = 1' with 'req.dl_max_conind = DLPI_MAX_CONIND' - Maintains full backwards compatibility Resolves XXX comment about magic number in pcap-dlpi.c line 1457.
guyharris
reviewed
Jul 23, 2025
| @@ -122,6 +122,12 @@ | |||
|
|
|||
| #define MAXDLBUF 8192 | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
As this is only used for HP-UX, should it be defined inside an #ifdef for HP-UX?
|
@killerdevildog, second warning for posting a software-generated pull request. |
|
The author has demanded explanations from me directly. Let me note the author has very recently forked more than 100 repositories and opened more than 50 pull requests, some of which are of a very similar quality, and some of which have already been rejected on very similar grounds. Excuse me, but you already know well what you are doing and your request for explanations is out of place. |
|
For posterity, the meaning of "1" is documented here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded magic number '1' in dlbindreq() with a descriptive constant DLPI_MAX_CONIND. This improves code readability and follows best practices for maintainable code.
Resolves XXX comment about magic number in pcap-dlpi.c line 1457.