Skip to content

Conversation

giucam
Copy link

@giucam giucam commented Jun 8, 2023

NodeId, LinkId and PinId are just glorified pointers. In some cases
32/64 bits of data may not be enough to identify an object, or the
objects may lack a stable pointer/id value.
This commit adds a way to specify custom data types for them:
similarly to ImGui, a IMGUI_NODE_EDITOR_USER_CONFIG macro can be set
before including imgui_node_editor.h. If defined, its value will be
used as a filename to be included at the top of imgui_node_editor.h.

In it, the macros IMGUI_NODE_EDITOR_CUSTOM_NODEID,
IMGUI_NODE_EDITOR_CUSTOM_PINID and IMGUI_NODE_EDITOR_CUSTOM_LINKID
may be defined as the names of the types to be used for them.
If one or more of them are not defined the old types will be used,
old code does not need to be changed.

The types used must be copy contructible, assignable and must provide
a few more functions, as in this example:
struct CustomId
{
CustomId(const CustomId &id);
CustomId &operator=(const CustomId &id);;

bool operator<(const CustomId &id) const;
bool operator==(const CustomId &id) const;;

std::string AsString() const;
static CustomId FromString(const char *str, const char *end);
bool IsValid() const;

static const CustomId Invalid;

};

A new example showcasing the functionality is added.

giucam and others added 2 commits June 8, 2023 10:31
NodeId, LinkId and PinId are just glorified pointers. In some cases
32/64 bits of data may not be enough to identify an object, or the
objects may lack a stable pointer/id value.
This commit adds a way to specify custom data types for them:
similarly to ImGui, a IMGUI_NODE_EDITOR_USER_CONFIG macro can be set
before including imgui_node_editor.h. If defined, its value will be
used as a filename to be included at the top of imgui_node_editor.h.

In it, the macros IMGUI_NODE_EDITOR_CUSTOM_NODEID,
IMGUI_NODE_EDITOR_CUSTOM_PINID and IMGUI_NODE_EDITOR_CUSTOM_LINKID
may be defined as the names of the types to be used for them.
If one or more of them are not defined the old types will be used,
old code does not need to be changed.

The types used must be copy contructible, assignable and must provide
a few more functions, as in this example:
struct CustomId
{
    CustomId(const CustomId &id);
    CustomId &operator=(const CustomId &id);;

    bool operator<(const CustomId &id) const;
    bool operator==(const CustomId &id) const;;

    std::string AsString() const;
    static CustomId FromString(std::string_view str);
    bool IsValid() const;

    static const CustomId Invalid;
};

A new example showcasing the functionality is added.
@QiuYilin
Copy link

I think providing some methods to convert graph data into IDs, or even restore graph data through IDs will make the project more convenient. Can you consider this further?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants