Skip to content

Update Datepicker onSelectedDateChanged signature to include isClearAction parameter #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update Datepicker onSelectedDateChanged signature to include isClearAction parameter #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aa5ed39
Update Datepicker onSelectedDateChanged signature to include isClearA…
bvedad Apr 16, 2024
0bd32a6
Merge branch 'main' into feat/datepicker-clear-functionality
bvedad Apr 17, 2024
e182bcb
changeset generated
bvedad Apr 17, 2024
d8e7cfe
Update .changeset/silent-cougars-serve.md
bvedad May 3, 2024
7dfafe8
Merge branch 'main' into feat/datepicker-clear-functionality
bvedad May 3, 2024
a3eea21
Merge branch 'main' into feat/datepicker-clear-functionality
bvedad May 22, 2024
62b2525
Merge branch 'main' into feat/datepicker-clear-functionality
bvedad Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/silent-cougars-serve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"flowbite-react": patch
---

Added isClearAction to onSelectedDateChanged to provide context for clear actions.
10 changes: 5 additions & 5 deletions packages/ui/src/components/Datepicker/Datepicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export interface DatepickerProps extends Omit<TextInputProps, "theme"> {
language?: string;
weekStart?: WeekStart;
theme?: DeepPartial<FlowbiteDatepickerTheme>;
onSelectedDateChanged?: (date: Date) => void;
onSelectedDateChanged?: (date: Date, isClearAction: boolean) => void;
}

const DatepickerRender: ForwardRefRenderFunction<DatepickerRef, DatepickerProps> = (
Expand Down Expand Up @@ -137,11 +137,11 @@ const DatepickerRender: ForwardRefRenderFunction<DatepickerRef, DatepickerProps>
const datepickerRef = useRef<HTMLDivElement>(null);

// Triggers when user select the date
const changeSelectedDate = (date: Date, useAutohide: boolean) => {
const changeSelectedDate = (date: Date, useAutohide: boolean, isClearAction?: boolean) => {
setSelectedDate(date);

if (onSelectedDateChanged) {
onSelectedDateChanged(date);
onSelectedDateChanged(date, isClearAction ?? false);
}

if (autoHide && view === Views.Days && useAutohide == true && !inline) {
Expand All @@ -150,7 +150,7 @@ const DatepickerRender: ForwardRefRenderFunction<DatepickerRef, DatepickerProps>
};

const clearDate = () => {
changeSelectedDate(defaultDate, true);
changeSelectedDate(defaultDate, true, true);
if (defaultDate) {
setViewDate(defaultDate);
}
Expand Down Expand Up @@ -336,7 +336,7 @@ const DatepickerRender: ForwardRefRenderFunction<DatepickerRef, DatepickerProps>
type="button"
className={twMerge(theme.popup.footer.button.base, theme.popup.footer.button.clear)}
onClick={() => {
changeSelectedDate(defaultDate, true);
changeSelectedDate(defaultDate, true, true);
if (defaultDate) {
setViewDate(defaultDate);
}
Expand Down