Skip to content

Add support for grouping dropdowns and buttons together in button group #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add support for grouping dropdowns and buttons together in button group #331

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7dc7314
feat: add support for grouping dropdowns and buttons together in butt…
tho-dan Nov 26, 2024
f3a356a
feat: add documentation section for grouping buttons and dropdowns to…
tho-dan Nov 26, 2024
ddc6620
chore: simplify button group with dropdown example
tho-dan Nov 26, 2024
fa0e251
chore: fix code style
tho-dan Dec 9, 2024
cb40d73
Merge branch 'main' into 330-support-dropdown-in-button-group
Sqrcz Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions docs/components/button-group.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<script setup>
import FwbButtonGroupExample from './buttonGroup/examples/FwbButtonGroupExample.vue'
import FwbButtonGroupExampleIcon from './buttonGroup/examples/FwbButtonGroupExampleIcon.vue'
import FwbButtonGroupExample from './buttonGroup/examples/FwbButtonGroupExample.vue';
import FwbButtonGroupExampleIcon from './buttonGroup/examples/FwbButtonGroupExampleIcon.vue';
import FwbButtonGroupExampleDropdown from './buttonGroup/examples/FwbButtonGroupExampleDropdown.vue';
</script>

# Vue Button Group - Flowbite
Expand Down Expand Up @@ -57,3 +58,36 @@ import { FwbButtonGroup, FwbButton } from 'flowbite-vue'
import { FwbButtonGroup, FwbButton } from 'flowbite-vue'
</script>
```

## Grouping buttons and dropdowns

You can also mix buttons with dropdowns inside the button group.
<fwb-button-group-example-dropdown />
```vue
<template>
<fwb-button-group>
<fwb-button>Button 1</fwb-button>
<fwb-button>Button 2</fwb-button>
<fwb-dropdown text="Dropdown">
<p class="px-4">
This is a test dropdown
</p>
</fwb-dropdown>
<fwb-dropdown text="Dropdown with list">
<fwb-list-group>
<fwb-list-group-item
v-for="item in ['This', 'is', 'a', 'list']"
:key="item"
hover
>
<a href="#">{{ item }}</a>
</fwb-list-group-item>
</fwb-list-group>
</fwb-dropdown>
</fwb-button-group>
</template>

<script setup>
import { FwbButtonGroup, FwbButton, FwbDropdown, FwbListGroupItem, FwbListGroup } from 'flowbite-vue'
</script>
```
28 changes: 28 additions & 0 deletions docs/components/buttonGroup/examples/FwbButtonGroupExampleDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<template>
<div class="vp-raw">
<fwb-button-group>
<fwb-button> Button 1 </fwb-button>
<fwb-button> Button 2 </fwb-button>
<fwb-dropdown text="Dropdown">
<p class="px-4">
This is a test dropdown
</p>
</fwb-dropdown>
<fwb-dropdown text="Dropdown with list">
<fwb-list-group>
<fwb-list-group-item
v-for="item in ['This', 'is', 'a', 'list']"
:key="item"
hover
>
<a href="#">{{ item }}</a>
</fwb-list-group-item>
</fwb-list-group>
</fwb-dropdown>
</fwb-button-group>
</div>
</template>

<script setup>
import { FwbButton, FwbButtonGroup, FwbDropdown, FwbListGroup, FwbListGroupItem } from '../../../../src/index'
</script>
11 changes: 8 additions & 3 deletions src/components/FwbButtonGroup/FwbButtonGroup.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,18 @@
</template>

<style>
.fwb-button-group > button {
.fwb-button-group > button,
.fwb-button-group > .fwb-dropdown button {
@apply rounded-none;
}
.fwb-button-group > button:first-child {

.fwb-button-group > button:first-child,
.fwb-button-group > .fwb-dropdown:first-child button {
@apply rounded-l-lg;
}
.fwb-button-group > button:last-child {

.fwb-button-group > button:last-child,
.fwb-button-group > .fwb-dropdown:last-child button {
@apply rounded-r-lg;
}
</style>
2 changes: 1 addition & 1 deletion src/components/FwbDropdown/FwbDropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
ref="wrapper"
class="inline-flex relative"
class="fwb-dropdown inline-flex relative"
>
<div class="inline-flex items-center">
<fwb-slot-listener @click="onToggle">
Expand Down