-
Notifications
You must be signed in to change notification settings - Fork 137
Close modal on esc keypress even when focusTrap is enabled #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for sensational-seahorse-8635f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughAdds escapeDeactivates: false to the modal’s focus-trap configuration to change Escape-key handling, and updates modal documentation to clarify that Escape still closes the modal. Changes
Sequence Diagram(s)sequenceDiagram
actor U as User
participant M as Modal
participant FT as Focus Trap
rect rgba(230, 245, 255, 0.5)
note over U,M: Open modal
U->>M: Open
M->>FT: Initialize useFocusTrap({ escapeDeactivates: false })
end
rect rgba(240, 255, 230, 0.5)
note over U,FT: Keypress: Escape
U->>FT: Press Escape
FT-->>M: Focus trap remains active (no deactivation)
M->>M: Close modal logic handles Escape
M-->>U: Modal closes
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Thank you 🙏
Fixes issue #404
Summary by CodeRabbit