Skip to content

test jack detection if is dsp d3 status - fix skip #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arikgreen merged 1 commit into from
Nov 28, 2025
Merged

test jack detection if is dsp d3 status - fix skip #1334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test-case/test-jack-detection-dsp-d3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,13 @@ main()
start_test

dlogi "Checking usbrelay availability..."
if ! command -v usbrelay > /dev/null; then
command -v usbrelay || {
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command -v usbrelay check will output to stdout when the command exists, which may clutter logs. The original code redirected this output to /dev/null. Consider adding > /dev/null to maintain clean output: command -v usbrelay > /dev/null || {

Suggested change
command -v usbrelay || {
command -v usbrelay > /dev/null || {

Copilot uses AI. Check for mistakes.
# If usbrelay package is not installed
skip_test "usbrelay command not found."
fi

if ! usbrelay_switch --debug > /dev/null; then
}
usbrelay_switch --debug || {
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usbrelay_switch --debug command will output debug information to stdout/stderr when it succeeds, which may clutter logs. The original code redirected this output to /dev/null. Consider adding > /dev/null to maintain clean output: usbrelay_switch --debug > /dev/null || {

Suggested change
usbrelay_switch --debug || {
usbrelay_switch --debug > /dev/null || {

Copilot uses AI. Check for mistakes.
skip_test "Failed to get usbrelay status."
fi
}

dlogi "Reset USB Relay - plug jack audio."
usbrelay_switch "$relay" 0
Expand Down