Skip to content

Audio: Volume: Fix a possible overflow in S24_LE format volume #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Aug 26, 2025
Merged

Audio: Volume: Fix a possible overflow in S24_LE format volume #10181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/audio/volume/volume_hifi3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ static void vol_s24_to_s24_s32(struct processing_module *mod, struct input_strea
out_sample = AE_MULFP32X2RS(volume, AE_SLAI32(in_sample, 8));
#endif

/* Shift and round for S24_LE */
out_sample = AE_SRAI32R(out_sample, 8);
/* Shift to S24_LE */
out_sample = AE_SRAI32(out_sample, 8);

/* Store the output sample */
AE_SA32X2_IP(out_sample, outu, out);
Expand Down
4 changes: 2 additions & 2 deletions src/audio/volume/volume_hifi3_with_peakvol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ static void vol_s24_to_s24_s32(struct processing_module *mod, struct input_strea
out_sample = AE_MULFP32X2RS(volume, AE_SLAI32(in_sample, 8));
#endif

/* Shift and round for S24_LE */
out_sample = AE_SRAI32R(out_sample, 8);
/* Shift to S24_LE */
out_sample = AE_SRAI32(out_sample, 8);
/* Store the output sample */
AE_S32_L_XP(out_sample, out, inc);
}
Expand Down
4 changes: 2 additions & 2 deletions src/audio/volume/volume_hifi4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ static void vol_s24_to_s24_s32(struct processing_module *mod, struct input_strea
out_sample = AE_MULFP32X2RS(volume, AE_SLAI32(in_sample, 8));
#endif

/* Shift and round for S24_LE */
out_sample = AE_SRAI32R(out_sample, 8);
/* Shift to S24_LE */
out_sample = AE_SRAI32(out_sample, 8);

/* Store the output sample */
AE_SA32X2_IP(out_sample, outu, out);
Expand Down
4 changes: 2 additions & 2 deletions src/audio/volume/volume_hifi4_with_peakvol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ static void vol_s24_to_s24_s32(struct processing_module *mod, struct input_strea
out_sample = AE_MULFP32X2RS(volume, AE_SLAI32(in_sample, 8));
#endif

/* Shift and round for S24_LE */
out_sample = AE_SRAI32R(out_sample, 8);
/* Shift to S24_LE */
out_sample = AE_SRAI32(out_sample, 8);

/* Store the output sample */
AE_SA32X2_IP(out_sample, outu, out);
Expand Down
Loading