Skip to content

lib-manager: fix use-after-free #10184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Aug 22, 2025
Merged

lib-manager: fix use-after-free #10184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/library_manager/lib_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,17 +649,16 @@ static struct comp_dev *lib_manager_module_create(const struct comp_driver *drv,

static void lib_manager_module_free(struct comp_dev *dev)
{
struct processing_module *mod = comp_mod(dev);
const struct comp_ipc_config *const config = &mod->dev->ipc_config;
uint32_t component_id = dev->ipc_config.id;
int ret;

/* This call invalidates dev, mod and config pointers! */
module_adapter_free(dev);

/* Free module resources allocated in L2 memory. */
ret = lib_manager_free_module(config->id);
ret = lib_manager_free_module(component_id);
if (ret < 0)
comp_err(dev, "lib_manager_free_module() failed!");
tr_err(&lib_manager_tr, "lib_manager_free_module() failed!");
}

static void lib_manager_prepare_module_adapter(struct comp_driver *drv, const struct sof_uuid *uuid)
Expand Down
Loading