-
Notifications
You must be signed in to change notification settings - Fork 349
Revert "audio: use zephyr/cache.h for cache flush/invalidate" #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f78acf4. Fixes build regression with testbuild. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous commit that replaced SOF's native cache operations with Zephyr cache APIs to fix a build regression in testbuild. The revert restores the original cache function calls and header includes across multiple audio subsystem files.
- Replaces
zephyr/cache.hincludes withrtos/cache.h - Reverts
sys_cache_data_flush_range()calls back todcache_writeback_region() - Reverts
sys_cache_data_invd_range()calls back todcache_invalidate_region()
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/include/sof/audio/audio_stream.h | Reverts header include and cache flush calls in audio stream writeback function |
| src/audio/copier/copier_ipcgtw.c | Removes zephyr cache header and reverts cache invalidate calls |
| src/audio/buffers/ring_buffer.c | Removes zephyr cache header and reverts cache operations in ring buffer functions |
| src/audio/buffers/comp_buffer.c | Moves cache header include and reverts cache flush call in buffer zero function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
singalsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fixes the issue, thanks Kai!
tmleman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix fuzz builds.
|
The Internal Intel test is failing on TGL to a failure that seems to be related to test infra. Fail on TGL and "06_00_TestHdaCodecLoopback", exception from test harnesss when "Unhandled Exception: System.BadImageFormatException". FYI @lrudyX @lgirdwood This is revert of a recent PR so I'd expect no issue in testing. |
This reverts commit f78acf4.
Fixes build regression with testbuild.