Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Sep 30, 2025

This reverts commit f78acf4.

Fixes build regression with testbuild.

This reverts commit f78acf4.

Fixes build regression with testbuild.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Copilot AI review requested due to automatic review settings September 30, 2025 08:16
@kv2019i kv2019i requested a review from singalsu September 30, 2025 08:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous commit that replaced SOF's native cache operations with Zephyr cache APIs to fix a build regression in testbuild. The revert restores the original cache function calls and header includes across multiple audio subsystem files.

  • Replaces zephyr/cache.h includes with rtos/cache.h
  • Reverts sys_cache_data_flush_range() calls back to dcache_writeback_region()
  • Reverts sys_cache_data_invd_range() calls back to dcache_invalidate_region()

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/include/sof/audio/audio_stream.h Reverts header include and cache flush calls in audio stream writeback function
src/audio/copier/copier_ipcgtw.c Removes zephyr cache header and reverts cache invalidate calls
src/audio/buffers/ring_buffer.c Removes zephyr cache header and reverts cache operations in ring buffer functions
src/audio/buffers/comp_buffer.c Moves cache header include and reverts cache flush call in buffer zero function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue, thanks Kai!

Copy link
Contributor

@tmleman tmleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix fuzz builds.

@kv2019i
Copy link
Collaborator Author

kv2019i commented Sep 30, 2025

The Internal Intel test is failing on TGL to a failure that seems to be related to test infra. Fail on TGL and "06_00_TestHdaCodecLoopback", exception from test harnesss when "Unhandled Exception: System.BadImageFormatException". FYI @lrudyX @lgirdwood

This is revert of a recent PR so I'd expect no issue in testing.

@lgirdwood lgirdwood merged commit 17dea29 into thesofproject:main Sep 30, 2025
34 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants