Tools: Topology: Add topologies for NVL platform with SDW & DMIC #10279
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds topology configurations for the NVL (Nova Lake) platform with SoundWire (SDW) and digital microphone (DMIC) support. The changes enable audio topology generation for various NVL hardware configurations including RT721/RT722 codecs and different microphone setups.
Key changes:
- Added comprehensive topology targets for NVL platform with various codec and microphone configurations
- Integrated NVL topology targets into the build system
- Added platform configuration mapping for NVL to reuse PTL settings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/topology/topology2/production/tplg-targets-ace4.cmake | New file defining 14 topology configurations for NVL platform with RT721/RT722 codecs and various DMIC setups |
| tools/topology/topology2/production/CMakeLists.txt | Added include for the new ace4 topology targets |
| tools/topology/topology2/development/tplg-targets.cmake | Added development topology for NVL nocodec configuration |
| tools/topology/topology2/cavs-sdw.conf | Added NVL platform mapping to reuse PTL configuration |
| tools/topology/topology2/cavs-nocodec.conf | Added NVL platform mapping to reuse PTL configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bardliao
left a comment
bardliao
left a comment
There was a problem hiding this comment.
I don't expect that the topology with PCH-DMIC is still needed. But it is harmless to have them.
| SDW_JACK_OUT_STREAM=Playback-SimpleJack,SDW_JACK_IN_STREAM=Capture-SimpleJack,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-nvl-rt721-4ch.bin,DMIC0_ENHANCED_CAPTURE=true,\ | ||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default,\ | ||
| DEEPBUFFER_FW_DMA_MS=10,DEEP_BUF_SPK=true" |
There was a problem hiding this comment.
I think we also need to topologies for the machines without DMIC (sans -2ch / -4ch).
New kernels will not going to need these - only the function fragments - but older kernels with backports will still need them.
There was a problem hiding this comment.
I was asked to create patch to build these topologies. Should this PR be dropped?
There was a problem hiding this comment.
I was asked to create patch to build these topologies. Should this PR be dropped?
Not necessary, adding the topologies without PCH DMIC into this PR should be good enough.
There was a problem hiding this comment.
@singalsu any update - we can merge this and follow up with a PR without PCH DMIC
There was a problem hiding this comment.
Yes, I don't see blockers for this, except that this adds quite many topologies those may become unused. But maybe we can also later delete builds of topologies those we notice are not needed.
There was a problem hiding this comment.
I still don't understand this, if we add the -Xch variants of monolithic topologies then we also need to add the no PCH-DMIC version(s).
If we say from now on that only function topologies are supported for NVL+, then none of the monolithic ones should be here.
This patch adds the nocodec topology for NVL platform. Since the topologies are identical to PTL, the special topologies for other rates and channels counts can be copied from the PTL builds. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
add_nvl_tplg
branch
from
a909a26 to
e363202
Compare
|
|
||
| # SSP topology for NVL | ||
| "cavs-nocodec\;sof-nvl-nocodec\;PLATFORM=nvl,NUM_DMICS=4,PDM1_MIC_A_ENABLE=1,PDM1_MIC_B_ENABLE=1,\ | ||
| PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-nvl-nocodec.bin" |
There was a problem hiding this comment.
Do we not need the nvl specific DMIC and SSP fragments still?
@bardliao ?
There was a problem hiding this comment.
We need DMIC and HDMI fragments. But I think it can be a different PR.
5 participants
No description provided.