xtensa-build-zephyr: pure comment/link to west config simplification #10307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Also fix the name of the west config class, see https://docs.zephyrproject.org/4.2.0/develop/west/west-apis.html #configuration-api Fixes 5a82b0a ("xtensa-build-zephyr.py: add new rimage_west_configuration()") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
The west class name has not changed, that comment has been incorrect forever. And there's no plan to change that class name either. The two fixes are actually unrelated to each other, sorry for any confusion. They just happen to be in the same area and they are both just comments. I'm the annoying person who keeps asking for separate commits and separate PRs but even I get "lazy" in cases like this :-) |
lgirdwood
approved these changes
Oct 19, 2025
kv2019i
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 5a82b0a ("xtensa-build-zephyr.py: add new rimage_west_configuration()")
cc: @thorsten-klein