boot_test: use generic Kconfig for CMake conditions #10308
Conversation
abonislawski
requested review from
dbaluta,
iuliana-prodan,
kv2019i and
lyakh
as code owners
There was a problem hiding this comment.
Pull Request Overview
Broadens the CMake condition so the boot test sources are included for all ACE platforms instead of only version 1.5.
- Replaces version-specific Kconfig symbol CONFIG_ACE_VERSION_1_5 with more general CONFIG_ACE
- Keeps existing conditional inclusion of vmh.c under CONFIG_SOF_BOOT_TEST
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zephyr/test/CMakeLists.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| if (CONFIG_ACE_VERSION_1_5) | |||
| if (CONFIG_ACE) | |||
There was a problem hiding this comment.
@abonislawski I think this is better, but I wonder if this could be made an ifdef on whether VMH is enabled or not? This would better scale up with different platforms...
There was a problem hiding this comment.
Definitely good idea! I just pushed new version with generic kconfigs
abonislawski
force-pushed
the
ztest_ace
branch
from
e824f3f to
326a53c
Compare
|
I think we've originally only enabled it for MTL to try and see what the performance impact would be... But if tests are passing and nobody objects - sure, the more testing, the better |
|
at least I wouldn't call this a "fix" - it wasn't an oversight, it was a conscious decision to limit the scope of the feature |
- Remove platform dependency - Add CONFIG_SOF_BOOT_TEST and CONFIG_VIRTUAL_HEAP dependency Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
ztest_ace
branch
from
326a53c to
867a646
Compare
|
Commit message updated with generic kconfigs |
abonislawski
changed the title
5 participants
Enable for all ACE platforms