Skip to content

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Oct 28, 2025

We have had sof-docs CI builds failing due to warnings that have not been addressed for more than 3 months. Limit the check to fatal errors to resume at least a barebones level of check for doxygen build target in the CI.

We have had sof-docs CI builds failing due to warnings that have not
been addressed for more than 3 months. Limit the check to fatal errors
to resume at least a barebones level of check for doxygen build
target in the CI.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i kv2019i force-pushed the 202510-ci-relax-doxygen branch from 80c9652 to 65ebdc1 Compare October 28, 2025 18:58
@kv2019i kv2019i marked this pull request as ready for review October 28, 2025 19:06
Copilot AI review requested due to automatic review settings October 28, 2025 19:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the documentation build process to prevent CI failures caused by Doxygen warnings. The change shifts from treating warnings as errors to only failing on fatal errors, allowing the CI to continue providing basic validation while known warnings remain unaddressed.

  • Disables WARN_AS_ERROR in the Doxygen configuration
  • Adds LAX=1 flag to the documentation build command in CI workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
doc/sof.doxygen.in Disables treating warnings as errors in Doxygen configuration
.github/workflows/sof-docs.yml Enables lax mode for the documentation build process

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

#FILTER_SOURCE_FILES = YES

HTML_TIMESTAMP = NO
WARN_AS_ERROR = NO
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Setting WARN_AS_ERROR = NO creates technical debt by allowing documentation warnings to accumulate. Consider creating a tracking issue to address the existing warnings and restore this setting to YES, or implement a gradual improvement plan to prevent new warnings while cleaning up existing ones.

Suggested change
WARN_AS_ERROR = NO
WARN_AS_ERROR = YES

Copilot uses AI. Check for mistakes.
@lgirdwood lgirdwood merged commit fb362d7 into thesofproject:main Oct 29, 2025
37 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants