LLEXT: fix a memory leak #9946
Merged
LLEXT: fix a memory leak #9946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take .bss into account when unmapping, similarly to mapping. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
approved these changes
Apr 1, 2025
lgirdwood
reviewed
Apr 1, 2025
| continue; | ||
|
|
||
| /* First user of this dependency, load it into SRAM */ | ||
| ret = llext_manager_load_module(dep); |
Member
There was a problem hiding this comment.
do we need to decrement n_dependent on loading failure ?
Collaborator
Author
There was a problem hiding this comment.
rrright, good catch! Updated.
Auxiliary modules have to be unloaded when the last user is freed. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a memory-leak from #9940 and a mis-calculated writable data size.