Skip to content

feat!: Update ReadLinesAsync to return IAsyncEnumerable<string> #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ted-Jin-Lab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat!: Update ReadLinesAsync to return IAsyncEnumerable<string> #1340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/ModularPipelines.Build/Modules/FindProjectDependenciesModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,13 @@ public class FindProjectDependenciesModule : Module<FindProjectDependenciesModul

foreach (var file in projects.Value!)
{
var contents = await file.ReadLinesAsync(cancellationToken);

foreach (var projectReferenceLine in contents.Where(x => x.Contains("<ProjectReference")))
await foreach (var projectReferenceLine in file.ReadLinesAsync(cancellationToken))
{
if (!projectReferenceLine.Contains("<ProjectReference"))
{
continue;
}

var name = projectReferenceLine.Split('\\').Last().Split('"').First();

var project = projects.Value!.FirstOrDefault(x => x.Name == name);
Expand Down
9 changes: 8 additions & 1 deletion src/ModularPipelines/FileSystem/File.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,14 @@ public Task<string> ReadAsync(CancellationToken cancellationToken = default)
return System.IO.File.ReadAllTextAsync(Path, cancellationToken);
}

public Task<string[]> ReadLinesAsync(CancellationToken cancellationToken = default)
public IAsyncEnumerable<string> ReadLinesAsync(CancellationToken cancellationToken = default)
{
ModuleLogger.Current.LogInformation("Reading File: {Path}", this);

return System.IO.File.ReadLinesAsync(Path, cancellationToken);
}

public Task<string[]> ReadAllLinesAsync(CancellationToken cancellationToken = default)
{
ModuleLogger.Current.LogInformation("Reading File: {Path}", this);

Expand Down
6 changes: 3 additions & 3 deletions test/ModularPipelines.UnitTests/FileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async Task ReadEmptyFile()
file.Create();

var plainText = await file.ReadAsync();
var lines = await file.ReadLinesAsync();
var lines = await file.ReadAllLinesAsync();
var bytes = await file.ReadBytesAsync();
var stream = await file.GetStream().ToMemoryStreamAsync();

Expand All @@ -126,7 +126,7 @@ public async Task ReadWriteFile()
await file.WriteAsync($"Hello{Environment.NewLine}world");

var plainText = await file.ReadAsync();
var lines = await file.ReadLinesAsync();
var lines = await file.ReadAllLinesAsync();
var bytes = await file.ReadBytesAsync();
var stream = await file.GetStream().ToMemoryStreamAsync();

Expand All @@ -152,7 +152,7 @@ await file.WriteAsync([
]);

var plainText = await file.ReadAsync();
var lines = await file.ReadLinesAsync();
var lines = await file.ReadAllLinesAsync();

using (Assert.Multiple())
{
Expand Down