Uptime scoring for nodes #1381
Open
Uptime scoring for nodes #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nabil salah <nabil.salah203@gmail.com>
Nabil-Salah
requested review from
AbdelrahmanElawady,
Eslam-Nawara,
Omarabdul3ziz,
ashraffouda,
mariobassem,
rawdaGastan,
sameh-farouk and
xmonader
as code owners
sameh-farouk
requested changes
Nov 13, 2025
| } | ||
|
|
||
| func (p *PostgresDatabase) calculateUptimeScore(ctx context.Context, healthReport types.HealthReport) float64 { | ||
| const thirtyDaysInSeconds = 30 * 24 * 60 |
Member
There was a problem hiding this comment.
thirtyDaysInSeconds Should be 30 * 24 * 60 * 60 ?
| endTime := thirtyDaysAgo + 60 | ||
|
|
||
| err = p.gormDB.WithContext(ctx).Table("health_report"). | ||
| Where("node_twin_id = ? AND updated_at BETWEEN ? AND ?", healthReport.NodeTwinId, startTime, endTime). |
Member
There was a problem hiding this comment.
I think this is a critical flaw for this PR
This assumes historic rows to subtract the value falling out of the 30-day window, but health_report currently stores only the latest state per node (see UpsertNodeHealth and also HealthReport struct, where NodeTwinId has a unique tag), and there’s no history table.
As a result, Score won’t reflect a true x-day window. Queries for “old” rows will not find meaningful data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
Checklist