-
Notifications
You must be signed in to change notification settings - Fork 39
Add discord link and relevant categories for Silksong #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* Add discord link to HK modding server * Added new categories for utility, cosmetic, accessibility, optimization, custom tools, custom crests, boss, and expansion. Based roughly on what we had for HK. https://github.com/hk-modding/modlinks/blob/main/Schemas/ModLinks.xml#L105-L118
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suppose some people might want a meme label, but those can be categorized differently probably
I considered a joke/meme category but I erred on the side of leaving it out because I recently saw people getting upset about quirrelboat being labeled as a joke; not having the category means we don't have to worry about whether the joke is "tasteful" or not |
Removed the 'Optimization' category and clarified 'Accessibility' category.
After discussing in HK modding discord we think optimization is too niche, so removed from this PR. Such mods would fall in under accessibility/utility |
Looks like removal of categories via ecosystem schema is currently prohibited. I'll get back to you after I've discussed this internally with the team. |
Removal of categories is prohibited in general because a package might have it in their manifest.json already, which would retroactively make the manifest not pass validation. In essence we'd be creating a data integrity error if we allowed categories to be removed once they've been "committed" to the ecosystem, as a part of package validation is checking the categories are actually real. So in order to make removals possible, we'd need to detach category definitions from the package validation flow. The best idea I have at the moment is to replace the In any case, as things stand right now, this PR is unmergeable because existing categories are being removed |
This is unfortunate, given that this was added to the ecosystem schema without any consultation of the HK modding community and we are now apparently locked with ambiguous/unhelpful categories that were created on our behalf. So getting a longer term fix with priority would be nice.
This behavior seems intuitive to me as a longer term option. Of course it carries the risk of a typo meaning that an intended tag is missed, but this can be remedied with a new version. In the short term, is it safe to re-label the categories? I have on my mind to add a |
While removals aren't possible, we could fairly easily add a soft-delete marker on the categories. This would make it so we can hide the soft-deleted categories from the site, but the old category IDs are still technically valid as far as validation rules go. Relabeling is completely fine and supported, although I think mod managers might not currently use the labels and instead assume a category ID maps 1:1 to a label. Mod managers should of course use the ecosystem schema (or the on-site API) as a reference on how to map category IDs to labels, but I'm unsure how many implement that. Either way at least the website will display categories according to their labels rather than IDs, and any consumers of packages should be doing that too, I'm just not sure how many do. |
Adding to this, I'd suggest you update this PR but instead of deleting the categories you want gone, add a new property under them as |
Main changes:
The only thing I'm not sure about here is whether it is safe to remove existing categories. The rationale for the 3 removed categories here are:
Currently draft to get more eyes from the broader community before merging.