- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5
Update Nimbus README with enw allowedHosts setup #1568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Nimbus README with enw allowedHosts setup #1568
Conversation
| Warning Rate limit exceeded@Oksamies has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 52 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the  We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
 WalkthroughThe apps/cyberstorm-remix README was updated: instead of instructing to uncomment a host in  Possibly related PRs
 Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
 ✅ Passed checks (2 passed)
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/cyberstorm-remix/README.md (1)
39-40: Tighten the wording in step 5.Change “in to” → “into” for smoother reading.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
- apps/cyberstorm-remix/README.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build
- GitHub Check: Generate visual diffs
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@          Coverage Diff           @@
##           master   #1568   +/-   ##
======================================
  Coverage    9.89%   9.89%           
======================================
  Files         308     308           
  Lines       22497   22497           
  Branches      404     404           
======================================
  Hits         2225    2225           
  Misses      20272   20272           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
        
          
                apps/cyberstorm-remix/README.md
              
                Outdated
          
        
      | ``` | ||
|  | ||
| 5. Uncomment the following string to the `allowedHosts` list in `vite.config.ts` ([link](https://github.com/thunderstore-io/thunderstore-ui/blob/f69ca05f2fe51320768aa4b934d17e40060192b5/apps/cyberstorm-remix/vite.config.ts#L13-L17)): `".thunderstore.temp"` | ||
| 5. Add your local test domains (e.g. `".thunderstore.temp"`) in to env variable `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=`; like this `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp`. (`localhost` is enabled by default) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this just be part of step 4? "Here's a example of file contents for development environment:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanted to keep it as a separate step to pronounce the thought process of "what is the local domain I'll be using". I can change it if my thinking sounds weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not exactly sure I understand what you mean by that? Doesn't the "Setup nginx proxy" phase and step 4 above pretty much tell the user to use thunderstore.temp as the local domain? Using something else just... doesn't work, the way all the pieces are currently set up?
I also noticed the main/root README sort of contradicts what's said in this README. The main README should perhaps be updated to link to this README rather than try to repeat the information there? Doesn't need to be part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the changes to your suggestions
9654c57    to
    5ad01db      
    Compare
  
    5ad01db    to
    56e9f94      
    Compare
  
    
No description provided.