Skip to content

Conversation

@Oksamies
Copy link
Contributor

@Oksamies Oksamies commented Oct 6, 2025

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Oct 6, 2025

Warning

Rate limit exceeded

@Oksamies has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5ad01db and 56e9f94.

📒 Files selected for processing (1)
  • apps/cyberstorm-remix/README.md (1 hunks)

Walkthrough

The apps/cyberstorm-remix README was updated: instead of instructing to uncomment a host in vite.config.ts, it now instructs setting local test domains via the environment variable __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS (e.g., __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp). Localhost remains enabled by default. No exported or public APIs were changed.

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The description is missing entirely and provides no context about the README update, making it impossible to determine its relevance to the changeset. Please add a brief description summarizing the changes to the README, specifically the new environment variable–based allowedHosts setup.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately reflects the primary change of updating the Nimbus README to include the allowedHosts setup instructions, though it contains a minor typographical error.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

Oksamies commented Oct 6, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Oksamies Oksamies requested a review from anttimaki October 6, 2025 10:49
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/cyberstorm-remix/README.md (1)

39-40: Tighten the wording in step 5.

Change “in to” → “into” for smoother reading.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a8c170 and 9654c57.

📒 Files selected for processing (1)
  • apps/cyberstorm-remix/README.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build
  • GitHub Check: Generate visual diffs

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.89%. Comparing base (ed81119) to head (56e9f94).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1568   +/-   ##
======================================
  Coverage    9.89%   9.89%           
======================================
  Files         308     308           
  Lines       22497   22497           
  Branches      404     404           
======================================
  Hits         2225    2225           
  Misses      20272   20272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

```

5. Uncomment the following string to the `allowedHosts` list in `vite.config.ts` ([link](https://github.com/thunderstore-io/thunderstore-ui/blob/f69ca05f2fe51320768aa4b934d17e40060192b5/apps/cyberstorm-remix/vite.config.ts#L13-L17)): `".thunderstore.temp"`
5. Add your local test domains (e.g. `".thunderstore.temp"`) in to env variable `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=`; like this `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=.thunderstore.temp`. (`localhost` is enabled by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be part of step 4? "Here's a example of file contents for development environment:"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to keep it as a separate step to pronounce the thought process of "what is the local domain I'll be using". I can change it if my thinking sounds weird

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not exactly sure I understand what you mean by that? Doesn't the "Setup nginx proxy" phase and step 4 above pretty much tell the user to use thunderstore.temp as the local domain? Using something else just... doesn't work, the way all the pieces are currently set up?

I also noticed the main/root README sort of contradicts what's said in this README. The main README should perhaps be updated to link to this README rather than try to repeat the information there? Doesn't need to be part of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the changes to your suggestions

@Oksamies Oksamies force-pushed the 10-06-update_nimbus_readme_with_enw_allowedhosts_setup branch from 9654c57 to 5ad01db Compare October 13, 2025 11:10
@Oksamies Oksamies requested a review from anttimaki October 21, 2025 11:51
@Oksamies Oksamies force-pushed the 10-06-update_nimbus_readme_with_enw_allowedhosts_setup branch from 5ad01db to 56e9f94 Compare October 21, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants