Nicholas Irving (nirving@darkedges.com) #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed an issue where the ClassLoader was being hit heavily to check to see what Spring Dialect was being used. Now check from one class instead of the ClassLoader. This improves a lock found in WebLogic 10.3.6, even after using a Filtered ClassLoader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking if what classes are on the ClassPath everytime with Class.forName, this change caches the class lookup for each Spring Dialect. I have seen similair changes in the code base to cache configuration items, but not the class. This improveda lock found in WebLogic when executing over 20+ requests per second.