Skip to content

Fix #175: Cannot call #fields.detailedErrors() from a Spring Webflow form #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from
Open

Fix #175: Cannot call #fields.detailedErrors() from a Spring Webflow form #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230d1b7
Fix #175: Cannot call #fields.detailedErrors() from a Spring Webflow …
TheConstructor Jul 8, 2018
01687ec
Backport fix #175: Cannot call #fields.detailedErrors() from a Spring…
TheConstructor Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion thymeleaf-spring3/src/main/java/org/thymeleaf/spring3/util/FieldUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,12 @@ private static List<DetailedError> computeDetailedErrors(
}

if (bindExpression != null) {
final List<FieldError> fieldErrors = errors.getFieldErrors(bindStatus.getExpression());
final List<FieldError> fieldErrors;
if (ALL_EXPRESSION.equals(bindExpression) || ALL_FIELDS.equals(bindExpression)) {
fieldErrors = errors.getFieldErrors();
} else {
fieldErrors = errors.getFieldErrors(bindExpression);
}
for (final FieldError fieldError : fieldErrors) {
final String message = requestContext.getMessage(fieldError, false);
final DetailedError errorObject =
Expand Down
7 changes: 6 additions & 1 deletion thymeleaf-spring4/src/main/java/org/thymeleaf/spring4/util/FieldUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,12 @@ private static List<DetailedError> computeDetailedErrors(
}

if (bindExpression != null) {
final List<FieldError> fieldErrors = errors.getFieldErrors(bindStatus.getExpression());
final List<FieldError> fieldErrors;
if (ALL_EXPRESSION.equals(bindExpression) || ALL_FIELDS.equals(bindExpression)) {
fieldErrors = errors.getFieldErrors();
} else {
fieldErrors = errors.getFieldErrors(bindExpression);
}
for (final FieldError fieldError : fieldErrors) {
final String message = requestContext.getMessage(fieldError, false);
final DetailedError errorObject =
Expand Down
7 changes: 6 additions & 1 deletion thymeleaf-spring5/src/main/java/org/thymeleaf/spring5/util/FieldUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ private static List<DetailedError> computeDetailedErrors(
}

if (bindExpression != null) {
final List<FieldError> fieldErrors = errors.getFieldErrors(bindStatus.getExpression());
final List<FieldError> fieldErrors;
if (ALL_EXPRESSION.equals(bindExpression) || ALL_FIELDS.equals(bindExpression)) {
fieldErrors = errors.getFieldErrors();
} else {
fieldErrors = errors.getFieldErrors(bindExpression);
}
for (final FieldError fieldError : fieldErrors) {
final String message = requestContext.getMessage(fieldError, false);
final DetailedError errorObject =
Expand Down