Skip to content

Add chimney to pois #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add chimney to pois #1930

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
418ad3f
Add chimney to pois
rwrx Sep 30, 2019
574a9f2
Add chimney to docs
Oct 1, 2019
a6fc985
Changed chimney min_zoom as in obelisk
rwrx Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/layers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
* `chemist` - A shop selling household chemicals, often including soaps, toothpaste and cosmetics.
* `childcare`
* `childrens_centre`
* `chimney`
* `chiropractor`
* `cinema`
* `clinic` with `kind_detail` property.
Expand Down
7 changes: 6 additions & 1 deletion yaml/pois.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ global:
- landuse: quarry
- leisure: [ dog_park, firepit, fishing, pitch, playground, slipway, swimming_area ]
- lock: yes
- man_made: [ adit, communications_tower, crane, mast, mineshaft, obelisk, observatory,
- man_made: [ adit, communications_tower, chimney, crane, mast, mineshaft, obelisk, observatory,
offshore_platform, petroleum_well, power_wind, telescope, water_tower,
water_well, watermill, windmill ]
- military: bunker
Expand Down Expand Up @@ -2640,6 +2640,11 @@ filters:
- shiploader
- tower_crane
then: {col: "crane:type"}
- filter: {man_made: chimney}
min_zoom: 14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please vary the min_zoom, like with like for obelisk:

  - filter: {man_made: obelisk}
    min_zoom:
      lookup:
        key: { call: { func: mz_to_float_meters, args: [ { col: height } ] } }
        op: '>='
        table:
          - [ 14, 20 ]  # z14 if height >= 20m
          - [ 15, 10 ]  # z15 if height >= 10m
        default: 16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have changed it as is in Obelisk.

output:
<<: *output_properties
kind: chimney
- filter: {leisure: water_park}
min_zoom: { clamp: { min: 13, max: 15, value: { sum: [ { col: zoom }, 2.34 ] } } }
output:
Expand Down