-
Notifications
You must be signed in to change notification settings - Fork 38
Update to tinkerbell/tinkerbell/api
for API definitions; Upgrade controller-runtime, CAPI, Go version, and all direct deps:
#468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacobweinstock
wants to merge
13
commits into
tinkerbell:main
Choose a base branch
from
jacobweinstock:new-tinkerbell
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+661
−509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to github.com/tinkerbell/tinkerbell/api: This is the new repo for all API definitions. Upgrade all go.mod dependencies: This uses the latest version of controller-runtime and capi. Fix kustomize files to remove deprecated fields: This gets Tilt and kustomize working properly. This was tested using the CAPT playground. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Move to a string instead of the deprecated capierrors.MachineStatusError. predicates.ClusterPausedTransitionsOrInfrastructureReady is the suggested function to use instead of the deprecated predicates.ClusterUnpausedAndInfrastructureReady. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The compatibility is being moved to each release. This is to help with keeping up the list. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Renaming to isoboot makes this mode name in line with netboot. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This gets the project to the latest Tinkerbell, CAPI, and controller runtime versions. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The Tinkerbell CAPT playground has a command for performing the pivot process. This doc update details this process some. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
The only change is the annotation denoting the kubebuilder version. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
tinkerbell/tinkerbell/api
for API definitions; Upgrade controller-runtime and capi:tinkerbell/tinkerbell/api
for API definitions; Upgrade controller-runtime, CAPI, Go version, and all direct deps:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Denotes a PR that introduces potentially breaking changes that require user action.
do-not-merge
Signal to Mergify to block merging of the PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to github.com/tinkerbell/tinkerbell/api: This is the new repo for all API definitions.
Upgrade all go.mod dependencies: This uses the latest version of controller-runtime and capi.
Fix kustomize files to remove deprecated fields: This gets Tilt and kustomize working properly. This was tested using the CAPT playground.
Note
This is a breaking change. The Tinkerbell stack helm chart <= 0.6.2 is not compatible with this change. CAPT versions with this in the release will require the following versions:
clusterctl >= 1.10.0
Tinkerbell Helm chart >= v0.18.1 (This chart is different than the previous one at https://github.com/tinkerbell/charts) https://github.com/tinkerbell/tinkerbell/pkgs/container/charts%2Ftinkerbell
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: