Add Honeywell HSC TruStability SPI+I2C pressure sensor driver #799
Conversation
soypat
commented
Oct 14, 2025
soypat
commented
- https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/zh-cn/localized/datasheets/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-ciid-151133-cn.pdf
| func main() { | ||
| bus := machine.I2C0 | ||
| err := bus.Configure(machine.I2CConfig{ | ||
| Frequency: 10_000, |
There was a problem hiding this comment.
10kHz is an unusually low frequency, is this intentional? (Many chips don't even support such low frequencies).
| buf [4]byte | ||
| } | ||
|
|
||
| func NewDevI2C(bus drivers.I2C, addr uint8, outMin, outMax uint16, pMin, pMax int32) *DevI2C { |
There was a problem hiding this comment.
Some I2C devices have 16-bit addresses, although I don't think we have any support for them at the moment. Perhaps it would be a good idea to use uint16 anyway?
| func NewDevI2C(bus drivers.I2C, addr uint8, outMin, outMax uint16, pMin, pMax int32) *DevI2C { | |
| func NewDevI2C(bus drivers.I2C, addr uint16, outMin, outMax uint16, pMin, pMax int32) *DevI2C { |
Also, can you add some doc comments?
| return h | ||
| } | ||
|
|
||
| func (d *DevI2C) Update(which drivers.Measurement) error { |
There was a problem hiding this comment.
Same here, please add documentation to this method (especially since it is exported).
| buf := &d.buf | ||
| const reg = 0 | ||
| value := (d.addr << 1) | 1 | ||
| err := d.bus.Tx(uint16(d.addr), []byte{reg, value}, buf[:]) |
There was a problem hiding this comment.
Note that the []byte{reg, value} will likely cause a heap allocation depending on the I2C implementation.
| buf [4]byte | ||
| } | ||
|
|
||
| func NewDevSPI(conn drivers.SPI, cs pinout, outMin, outMax uint16, pMin, pMax int32) (*DevSPI, error) { |
There was a problem hiding this comment.
Same here, this should get some explanation. At least clarifying with parameters like outMin mean.
| return h, nil | ||
| } | ||
|
|
||
| // Update implements the sensor interface. |
There was a problem hiding this comment.
That's technically correct, but not super helpful to users.
What about something like
Update reads the sensor values from the device. The values are stored in the driver object, and can be read with the
PressureandTemperaturemethods.
| } | ||
|
|
||
| // Temperature returns temperature in milliKelvin [mK]. | ||
| func (d *dev) Temperature() int32 { |
There was a problem hiding this comment.
2 participants
