lsm9ds1: avoid unnecessary heap allocations #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soypat
approved these changes
Oct 22, 2025
| if err != nil || data[0] != 0x68 { | ||
| return false | ||
| } | ||
| data, err = d.readBytes(d.MagAddress, WHO_AM_I_M, 1) |
There was a problem hiding this comment.
not required, but this could be rewritten as d.readByte (single byte return)
There was a problem hiding this comment.
Also heads up: regmap package implements read/write logic related to heapless register mapped peripherals, like this one https://github.com/tinygo-org/drivers/blob/dev/internal/regmap/devices.go
May help out in future modernizations :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-uses internal buffer to avoid unnecessary heap allocations in
lsm9ds1driver; switches away from the legacy I2C interface.Same as #766 but for
lsm9ds1driver.