-
Notifications
You must be signed in to change notification settings - Fork 994
feat(optimizer)!: Annotate type for snowflake SEARCH function #5985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer)!: Annotate type for snowflake SEARCH function #5985
Conversation
Before adding
After adding
@georgesittas , do we need to implement parsing for |
We must ensure that we don't break its parsing, or for that matter, the parsing of any The reason we focus on that whenever we introduce a new expression is due to this line here, which automatically introduces parsing across all dialects using the function's SQLGlot is lenient enough in the regard that any function that is not recognized is stored into an "Anonymous" expression; A new |
For
Only thing that might not work properly is : Semantic AST structure for ANALYZER parameter when used alone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just sanity checking: no other dialect supports SEARCH
? With or without the same semantics. It just seems like a pretty common name for a function to not double-check this.
4df1606
to
eb52011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _build_search
helper can be simplified further. I'll do it as a follow-up and share here.
* feat(optimizer)!: Annotate type for snowflake SEARCH function * fix: Fix parsing and AST generation * fix: Address review comments * fix: modified tests * fix(tests)!: Fixed failing tests
Annotate type for snowflake SEARCH function.
Documentation:
https://docs.snowflake.com/en/sql-reference/functions/search