feat(hive,spark)!: Support CHANGE COLUMN statements in Hive and CHANGE/ALTER COLUMN statements in Spark #6004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, we'll take a look soon. |
georgesittas
reviewed
Oct 7, 2025
* updated syntax handling constant name * Inherit ALTER_PARSERS from parser.Parser * fix column name parsing * revised rename handling
georgesittas
approved these changes
Oct 8, 2025
sqlglot/dialects/spark2.py
Outdated
| if new_name == this: | ||
| if comment: | ||
| return f"ALTER COLUMN {this} COMMENT {comment}" | ||
| return super(Hive.Generator, self).altercolumn_sql(expression) |
There was a problem hiding this comment.
We can simplify this a bit right?
Suggested change
| return super(Hive.Generator, self).altercolumn_sql(expression) | |
| return super().altercolumn_sql(expression) |
There was a problem hiding this comment.
Ended up reverting this, it seems like it didn't like it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation:
I validated that the test case output were considered syntactically valid by their respective engines.