Skip to content

tokio/interval: Fix overflow for interval tick #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

tokio/interval: Fix overflow for interval tick #7193

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47ee3e1
tokio/interval: Fix overflow for interval tick
lexnv Mar 4, 2025
2340ec7
tokio/interval: Use saturating duration instead
lexnv Mar 4, 2025
a11961a
tokio/interval: Fix overflows in MissedTickBehavior
lexnv Mar 4, 2025
2bcccc0
tokio/tests: Adjust interval panic test
lexnv Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tokio/src/time/interval.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,12 @@ impl Interval {
// However, if a tick took excessively long and we are now behind,
// schedule the next tick according to how the user specified with
// `MissedTickBehavior`
let next = if now > timeout + Duration::from_millis(5) {

let next = if now
> timeout
.checked_add(Duration::from_millis(5))
.unwrap_or_else(Instant::far_future)
{
self.missed_tick_behavior
.next_timeout(timeout, now, self.period)
} else {
Expand Down