tokio: use cargo feature for taskdump instead of cfg #7655
+111
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-current-thread
ADD-SP
force-pushed
the
add_sp/runtime-taskdump-cargo-feature
branch
15 times, most recently
from
8380c3b to
9a14d97
Compare
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
ADD-SP
force-pushed
the
add_sp/runtime-taskdump-cargo-feature
branch
from
9a14d97 to
e4ba090
Compare
ADD-SP
commented
Oct 1, 2025
| toolchain: ${{ matrix.rust }} | ||
| # `check-external-types` requires a specific Rust nightly version. See | ||
| # the README for details: https://github.com/awslabs/cargo-check-external-types | ||
| toolchain: nightly-2025-08-06 |
There was a problem hiding this comment.
We bump the toolchain due to the MSRV of backtrace crate.
Stderr: error: rustc 1.81.0-nightly is not supported by the following package:
backtrace@0.3.76 requires rustc 1.82.0
Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.81.0-nightly
ADD-SP
commented
Oct 1, 2025
Comment on lines
737
to
+738
| features: | ||
| name: features ${{ matrix.name }} | ||
| name: features exclude ${{ matrix.name }} |
There was a problem hiding this comment.
This changed the name of this job, we need to update the repo setting to unblock the CI.
ADD-SP
commented
Oct 1, 2025
Comment on lines
+510
to
+516
| strategy: | ||
| matrix: | ||
| target: | ||
| - name: x86_64-unknown-haiku | ||
| exclude_features: "taskdump" # taskdump is only available on Linux | ||
| - name: armv7-sony-vita-newlibeabihf | ||
| exclude_features: "process,signal,rt-process-signal,full" | ||
| exclude_features: "process,signal,rt-process-signal,full,taskdump" |
There was a problem hiding this comment.
This changed the matrix, and also changed the name of this job, we need to change the repo setting to unblock the CI.
See also https://github.com/tokio-rs/tokio/pull/7655/files#r2393408483.
Darksonn
reviewed
Oct 1, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
438
to
453
| run: cargo test --workspace --features $TOKIO_STABLE_FEATURES --target x86_64-unknown-linux-gnu --tests -- --test-threads 1 --nocapture | ||
| run: | | ||
| cargo test \ | ||
| --workspace \ | ||
| --features $TOKIO_STABLE_FEATURES \ | ||
| --target x86_64-unknown-linux-gnu \ | ||
| --tests \ | ||
| -- \ | ||
| --test-threads 1 \ | ||
| --nocapture |
There was a problem hiding this comment.
It looks like there are a fair number of changes that don't actually change anything.
There was a problem hiding this comment.
You are right, this is because of the very long command in a single line, which is hard to read.
There was a problem hiding this comment.
I have reverted all unrelated changes
Signed-off-by: ADD-SP <qiqi.zhang@konghq.com>
github-actions
bot
added
R-loom-current-thread
ADD-SP
removed
R-loom-sync
github-actions
bot
added
R-loom-current-thread
ADD-SP
removed
R-loom-sync
github-actions
bot
added
R-loom-current-thread
ADD-SP
removed
R-loom-sync
github-actions
bot
added
R-loom-current-thread
ADD-SP
removed
R-loom-sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5875