Skip to content

Lazy load public key for boost start time for both unit test and app #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Lazy load public key for boost start time for both unit test and app #81

wants to merge 2 commits into from

Conversation

@kidylee
Copy link

@kidylee kidylee commented Mar 13, 2023

JWK init method call _refresh token internally, which significantly slow down unit test and app start time, is not necessary as lone as other methods checking refresh properly. In this case, only expires takes the role.

Fix issue #77

hardbyte
hardbyte approved these changes Jun 20, 2023
View reviewed changes
Copy link

@hardbyte hardbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be great to merge and include in a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hardbyte hardbyte hardbyte approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kidylee @hardbyte