Skip to content

Restore terminal panel size when hide #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −1
Open

Restore terminal panel size when hide #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eab1fd9
🔨 update: restore terminal panel size when hide
hsayed21 Nov 13, 2024
48915dc
🔨 update: also handle terminal size when killTerminalAfterUse and res…
hsayed21 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ let PACKAGE: any;
let term: vscode.Terminal;
let previousActiveTerminal: vscode.Terminal | null;
let isExtensionChangedTerminal = false;
let isTerminalMaximized = false;

//
// Define the commands we expose. URIs are populated upon extension activation
Expand Down Expand Up @@ -620,6 +621,9 @@ function handleCanaryFileChange() {
// We set a timeout here to address #56. Don't have a good hypothesis as to why this works but
// it seems to fix the issue consistently.
setTimeout(() => term.dispose(), 100);
if (CFG.showMaximizedTerminal && isTerminalMaximized)
vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
isTerminalMaximized = false;
}

fs.readFile(CFG.canaryFile, { encoding: 'utf-8' }, (err, data) => {
Expand All @@ -640,9 +644,15 @@ function handleCanaryFileChange() {
}

if (commandWasSuccess && CFG.hideTerminalAfterSuccess) {
if (CFG.showMaximizedTerminal && isTerminalMaximized)
vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
term.hide();
isTerminalMaximized = false;
} else if (!commandWasSuccess && CFG.hideTerminalAfterFail) {
if (CFG.showMaximizedTerminal && isTerminalMaximized)
vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
term.hide();
isTerminalMaximized = false;
} else {
// Don't hide the terminal and make clippy angry
}
Expand All @@ -659,6 +669,9 @@ function handleTerminalFocusRestore(commandWasSuccess: boolean) {
previousActiveTerminal?.hide();
previousActiveTerminal = null;
isExtensionChangedTerminal = false;
if (CFG.showMaximizedTerminal && isTerminalMaximized)
vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
isTerminalMaximized = false;
disposable.dispose();
}
});
Expand Down Expand Up @@ -811,7 +824,10 @@ async function executeTerminalCommand(cmd: string) {
if (cbResult === true) {
term.sendText(getCommandString(commands[cmd]));
if (CFG.showMaximizedTerminal) {
vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
await vscode.commands.executeCommand('workbench.action.closeSidebar');
await vscode.commands.executeCommand("workbench.action.closeAuxiliaryBar");
await vscode.commands.executeCommand('workbench.action.toggleMaximizedPanel');
isTerminalMaximized = true;
}
if (CFG.restoreFocusTerminal) {
previousActiveTerminal = vscode.window.activeTerminal ?? null;
Expand Down