Better handling of comma-delimited BA IDs #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| export function transformArray({ value }: { value: string }) { | ||
| return Array.isArray(value) ? value : [value]; | ||
| export function transformArray({ value }: { value: unknown }) { | ||
| if (value === undefined || value === null) return undefined; |
There was a problem hiding this comment.
[correctness]
Returning undefined when value is undefined or null may lead to unexpected behavior if the caller expects an array. Consider returning an empty array instead to maintain consistent return types.
| return [v]; | ||
| }; | ||
|
|
||
| return Array.isArray(value) ? value.flatMap(splitIfString) : splitIfString(value); |
There was a problem hiding this comment.
[💡 design]
Using flatMap here is efficient for flattening arrays, but ensure that the caller is aware that nested arrays will be flattened, which might not be the intended behavior if the input is expected to be a single-level array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.