Skip to content

Mark trait U16UtfExt as unsafe as an incorrect implementation could lead to undefined behaviour. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmoxb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark trait U16UtfExt as unsafe as an incorrect implementation could lead to undefined behaviour. #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/traits.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,10 @@ impl U8UtfExt for u8 {


/// Methods for working with `u16`s as UTF-16 units.
pub trait U16UtfExt {
///
/// This trait is marked as unsafe because avoiding undefined behaviour
/// necessarily depends on it being implemented correctly.
pub unsafe trait U16UtfExt {
/// Will you need an extra unit to complete this codepoint?
///
/// Returns `Err` for trailing surrogates, `Ok(true)` for leading surrogates,
Expand All @@ -132,7 +135,7 @@ pub trait U16UtfExt {
/// Is basically an unchecked variant of `utf16_needs_extra_unit()`.
fn is_utf16_leading_surrogate(self) -> bool;
}
impl U16UtfExt for u16 {
unsafe impl U16UtfExt for u16 {
#[inline]
fn utf16_needs_extra_unit(self) -> Result<bool,Utf16FirstUnitError> {
match self {
Expand Down