feat: add support for vultr api v2

[dhruvkelawala]

Description

Added support for Vultr Api v2 as new accounts on Vultr won't be able to use v1 api. Old accounts will be unable to use v1 api after June 2023.

Motivation and Context

This change makes sure AlgoVPN can be use by new and old users of Vultr

Fixes #14580

How Has This Been Tested?

Tested by Creating a VPS on Vultr with Ubuntu on my macbook m1

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[CLAassistant]

All committers have signed the CLA.

[cooper667]

👍 Worked well for me, thanks

[dhruvkelawala]

Waiting for it to be merged. Not sure if it will ever be 😂

[mkurapov]

This worked for me, thank you!

[mkurapov]

When I reached the "Enter the local path to your configuration INI file" prompt, I left it blank in hopes it would use ~/.vultr.ini by default, but I got an error:

"msg": "An unhandled exception occurred while running the lookup plugin 'ansible.builtin.ini'. Error was a <class 'ansible.errors.AnsibleParserError'>, original message: an error occurred while trying to read the file '/Users/max/dev/algo/roles/cloud-vultr/': [Errno 21] Is a directory:

I'm guessing it didn't like the empty input?

However, after entering ~/.vultr.ini directly, everything worked for me

[dhruvkelawala]

Thanks for the review! Please feel free to merge 🙂

[dhruvkelawala]

@pentest01 @mkurapov Any plans to merge this and make a release?

[amitai]

Hi, would love to see this released.

[amitai]

I tried with this fork and still got the API error:

TASK [cloud-vultr : Creating a firewall group] *********************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Reached API retries limit 5 for URL https://api.vultr.com/v1/firewall/group_list, method GET with data None. Returned 503, with body: HTTP Error 503: API v1 Gone b'Sorry, all newly created accounts are forbidden from using API v1, all other accounts are able to use this deprecated API until September 30, 2023 at which point Vultr API v1 will be sunset. Please use API v2.'", "vultr_api": {"api_account": "default", "api_endpoint": "https://api.vultr.com", "api_retries": 5, "api_retry_max_delay": 12, "api_timeout": 60}, "vultr_firewall_group": {}}

[jackivanov]

Sorry for my delay. Feel free to rebase and I'll review

[dhruvkelawala]

Will do it

[dguido]

Thank you @dhruvkelawala for your contribution! Since this PR has merge conflicts and is from March 2023, I've created a new PR #14773 that incorporates your Vultr API v2 updates with conflict resolution.

Closing this in favor of #14773.