Skip to content

Fix #40 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aviggiano wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #40 #65

aviggiano wants to merge 1 commit into from

Conversation

@aviggiano
Copy link

@aviggiano aviggiano commented Oct 31, 2024

Fix #40

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@fcasal
Copy link
Collaborator

fcasal commented Oct 31, 2024

Hi @aviggiano thanks for the contribution.
I would propose having this behavior behind a configuration in settings.

With respect to the implementation, the sorting is done on the decoration function every time it is called. This should probably be done when items are added to the treeEntries object instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vasco-jofra Vasco-jofra Awaiting requested review from Vasco-jofra Vasco-jofra is a code owner

@fcasal fcasal Awaiting requested review from fcasal fcasal is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Sort issues by name

3 participants

@aviggiano @CLAassistant @fcasal