Skip to content

packaging: Move to pyproject.toml setup (PEP517) #9563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

packaging: Move to pyproject.toml setup (PEP517) #9563

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b32777
packaging: Move to pyproject.toml setup (PEP517)
nicholasjng Oct 1, 2025
16e44f1
fix pyproject layout as per review comments
nicholasjng Oct 5, 2025
eff4044
Restrict setuptools to >=77 for PEP639 support
nicholasjng Oct 6, 2025
50a5bb0
refactor(pyproject): rewrite extras as PEP735 dependency groups
nicholasjng Oct 6, 2025
d54cdf1
revert all and aws-iam to be extras
nicholasjng Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions clients/python-wrapper/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
[build-system]
requires = ["setuptools"]
build-backend = "setuptools.build_meta"

[project]
name = "lakefs"
version = "0.14.0"
description = "lakeFS Python SDK Wrapper"
keywords = ["OpenAPI", "OpenAPI-Generator", "lakeFS API", "Python Wrapper"]
requires-python = ">=3.9"
readme = "README.md"
license = "Apache-2.0"
authors = [
{ name = "Treeverse", email = "services@treeverse.io" },
]
dependencies = [
"lakefs-sdk>=1.50,< 2",
"pyyaml~=6.0.1",
]
classifiers = [
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python :: 3",
"Topic :: Software Development :: Libraries :: Python Modules",
"Topic :: Software Development :: Version Control",
"Topic :: Utilities",
"Typing :: Typed",
]

[project.optional-dependencies]
all = [ "boto3 >= 1.26.0" ]
aws-iam = [ "boto3 >= 1.26.0" ]
Comment on lines +31 to +32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, dependency-groups and extras (aka project.optional-dependencies) aren't the same thing. extras are for package distributions whereas dependency-groups are project dependencies, similar to requirements.txt files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, so test moves into a dependency group, while all and aws-iam return to optional-dependencies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, looks good as you have done. :)

test = [
Copy link
Contributor

@skshetry skshetry Oct 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good case for dependency-groups instead of introducing a new extra, but that's upto the maintainers to decide. Alternatively, this could be removed as there is requirements.txt for testing.

"pytest ~= 7.4.3",
"pytest-datafiles ~= 3.0.0",
"pandas >= 2.1.4,<3",
"pyarrow >= 14.0.1,<20",
"pillow >= 10.3.0,<12"
]

[project.urls]
Homepage = "https://github.com/treeverse/lakeFS/tree/master/clients/python-wrapper"

[tool.setuptools.packages.find]
include = ["lakectl", "lakefs"]

[tool.setuptools.package-data]
lakefs = ["py.typed"]
49 changes: 0 additions & 49 deletions clients/python-wrapper/setup.py
View file
Open in desktop

This file was deleted.