-
Notifications
You must be signed in to change notification settings - Fork 400
packaging: Move to pyproject.toml setup (PEP517) #9563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicholasjng
wants to merge
5
commits into
treeverse:master
Choose a base branch
from
nicholasjng:add-pyproject-toml
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+50
−49
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6b32777
packaging: Move to pyproject.toml setup (PEP517)
nicholasjng 16e44f1
fix pyproject layout as per review comments
nicholasjng eff4044
Restrict setuptools to >=77 for PEP639 support
nicholasjng 50a5bb0
refactor(pyproject): rewrite extras as PEP735 dependency groups
nicholasjng d54cdf1
revert all and aws-iam to be extras
nicholasjng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
[build-system] | ||
requires = ["setuptools>=77"] | ||
build-backend = "setuptools.build_meta" | ||
|
||
[project] | ||
name = "lakefs" | ||
version = "0.14.0" | ||
description = "lakeFS Python SDK Wrapper" | ||
keywords = ["OpenAPI", "OpenAPI-Generator", "lakeFS API", "Python Wrapper"] | ||
requires-python = ">=3.9" | ||
readme = "README.md" | ||
license = "Apache-2.0" | ||
authors = [ | ||
{ name = "Treeverse", email = "services@treeverse.io" }, | ||
] | ||
dependencies = [ | ||
"lakefs-sdk>=1.50,< 2", | ||
"pyyaml~=6.0.1", | ||
] | ||
classifiers = [ | ||
"Intended Audience :: Developers", | ||
"Operating System :: OS Independent", | ||
"Programming Language :: Python :: 3", | ||
"Topic :: Software Development :: Libraries :: Python Modules", | ||
"Topic :: Software Development :: Version Control", | ||
"Topic :: Utilities", | ||
"Typing :: Typed", | ||
] | ||
|
||
[project.optional-dependencies] | ||
all = [ "boto3 >= 1.26.0" ] | ||
aws-iam = [ "boto3 >= 1.26.0" ] | ||
|
||
[dependency-groups] | ||
test = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like a good case for |
||
"pytest ~= 7.4.3", | ||
"pytest-datafiles ~= 3.0.0", | ||
"pandas >= 2.1.4,<3", | ||
"pyarrow >= 14.0.1,<20", | ||
"pillow >= 10.3.0,<12" | ||
] | ||
|
||
[project.urls] | ||
Homepage = "https://github.com/treeverse/lakeFS/tree/master/clients/python-wrapper" | ||
|
||
[tool.setuptools.packages.find] | ||
include = ["lakectl", "lakefs"] | ||
|
||
[tool.setuptools.package-data] | ||
lakefs = ["py.typed"] |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi,
dependency-groups
andextras
(akaproject.optional-dependencies
) aren't the same thing.extras
are for package distributions whereasdependency-groups
are project dependencies, similar torequirements.txt
files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, so
test
moves into a dependency group, whileall
andaws-iam
return tooptional-dependencies
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, looks good as you have done. :)