Skip to content

feat(core/solana): optional program reference for SetComputeUnitLimit #6047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(core/solana): optional program reference for SetComputeUnitLimit #6047

wants to merge 1 commit into from

Conversation

@martykan
Copy link
Member

@martykan martykan commented Oct 20, 2025 •
edited
Loading

Related issue: #6048

This PR updates the definitions, to make it possible to reference the account.

Example:

$ SOLTX=800100050981d4ccaa3499657325d922e14e5f3bd45d961b3908aff41de4fc455aaeb326ef516d44e2cc8ae4a0b38270ecf16c4d0d696927138fec2715b500dad10fdb0d759387f450512fa496f134322eecff547637539405c882795d61e646b6b4c0bc8163f4c17d5adc2eac654eae3bdc601b1aa9714c1bdca2e0867fe3168cd6d0c05d0306466fe5211732ffecadba72c39be7bc8ce5bbc5f7126b2c439b3a4000000008ad793b39fdaa82ae0a6825138abf619e7e006807552ccafc7207b4800000008c97258f4e2489f1bb3d1029148e0d830b5a1399daff1084048e7bd8dbe9f8590954dbbe9ec960c98a7a293fe21336966fe180d151ae4b8179561f89854a53f606a7d517192c5c51218cc94c3d4af17f58daee089ba1fd44e3dbd98a0000000062c0ee5cde17180d73a3aae79f5261b7e51bc703508f460c94c99ba03147c8fe070401050502c05c150004000903020000000000000006060001000a0c0b0101070602090000080c08fef34862fb82a8d507070302090000080c2a6f11b9fa3c7a26fe00004173676172643a20312020202020202020202020202020202020202020202020070203000bdb56496a38da806d000001070203000bc25cccdff6bc1fcb00000102d8d4fd4eb6c20bd6f991963c108aa46df11c2499c90b06a4c24cdd1ac088701d00021003dc4e362a5ee990ffaf0a05fa6cafb44c532d587cf61149d88094b138c2357037018301c8
$ core/emu.py -sea -c trezorctl -v solana sign-tx -n 'm/44h/501h/0h/0h' $SOLTX

@trezor-bot trezor-bot bot added this to Firmware Oct 20, 2025
@github-project-automation github-project-automation bot moved this to 🔎 Needs review in Firmware Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025 •
edited
Loading

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 18888089442

@martykan martykan force-pushed the fix/solana-jito-bundle branch from 6231ba7 to 4d92ed4 Compare October 20, 2025 14:38
@martykan martykan force-pushed the fix/solana-jito-bundle branch from 4d92ed4 to 1193edd Compare October 20, 2025 15:23
@martykan martykan marked this pull request as ready for review October 21, 2025 12:06
@martykan martykan requested a review from obrusvit as a code owner October 21, 2025 12:06
obrusvit
obrusvit reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update fixtures with the new test for all translations.

core/.changelog.d/6048.fixed
@@ -0,0 +1,2 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra newline

@obrusvit obrusvit added the translations Put this label on a PR to run tests in all languages label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obrusvit obrusvit obrusvit left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

translations Put this label on a PR to run tests in all languages

Projects

Firmware
Status: 🔎 Needs review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martykan @obrusvit