feat(suite): Update troubleshooting tips #22182
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclavik
force-pushed
the
update-troubleshooting-tips
branch
from
0b7b77b to
b33119b
Compare
|
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
jvaclavik
force-pushed
the
update-troubleshooting-tips
branch
from
b33119b to
07af187
Compare
jvaclavik
force-pushed
the
update-troubleshooting-tips
branch
from
07af187 to
222034a
Compare
jvaclavik
commented
Oct 4, 2025
| expect(findByTestId('@connect-device-prompt')).not.toBeNull(); | ||
| expect(findByTestId(/TR_DEVICE_IN_BOOTLOADER/)).not.toBeNull(); | ||
| expect(findByTestId('TR_DEVICE_CONNECTED_BOOTLOADER')).not.toBeNull(); | ||
| fireEvent.click(findByTestId('@onboarding/troubleshooting-tips/button')); |
There was a problem hiding this comment.
IMHO it's really bad practice to check hidden content, it was pretty hard to debug 🤷♂️
Now we click first before we check.
jvaclavik
force-pushed
the
update-troubleshooting-tips
branch
from
c7072c1 to
330c22c
Compare
seibei-iguchi
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR ready, but waiting for merging this: #22094
Idea
Don't you see your trezor?andTroubleshooting tipsbuttons (see screenshot below) have similar intention (something is not working, so how to fix the issue?). But visual representation and behaviour of these two buttons were totally different. I unified these two actions to similar experience in this PR.Related Issue
Resolve
Screenshots:
Welcome screen
Welcome screen (non-subtle button)
It's for cases where Troubleshooting button is now expanded by default (there is no other primary action)
Troubleshooting Modal
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents